Project

General

Profile

Actions

Backport #4098

closed

URI.decode_www_form hangs for some input strings

Added by iconara (Theo Hultberg) over 13 years ago. Updated almost 13 years ago.

Status:
Closed
[ruby-core:33464]

Description

=begin
Running

require 'uri'
URI.decode_www_form('a=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA&b')

will hang seemingly forever. If you decrease the number of A's you will eventually see that it just takes a very, very long time to realize that the string is a malformed query string (there's no = in the last parameter). The culprit is line 828 of uri/common.rb, which looks like this:

unless /\A#{WFKV_}=#{WFKV_}(?:[;&]#{WFKV_}=#{WFKV_})*\z/o =~ str

I haven't even tried to decode that regexp, but it's clear that with a string like the one above it will take a very long time to realize that it can't match.
=end

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0