https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112011-07-01T14:28:50ZRuby Issue Tracking SystemRuby master - Bug #4956: [PATCH] string.c (tr_s_bang): fix leak with heap stringshttps://bugs.ruby-lang.org/issues/4956?journal_id=187352011-07-01T14:28:50Znaruse (Yui NARUSE)naruse@airemix.jp
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r32349.<br>
Eric, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<ul>
<li>string.c (tr_trans): free heap ptr when the str is not embeded.<br>
patched by Eric Wong. [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: [PATCH] string.c (tr_s_bang): fix leak with heap strings (Closed)" href="https://bugs.ruby-lang.org/issues/4956">#4956</a>] <a href="/issues/4956">[ruby-core:37708]</a></li>
</ul> Ruby master - Bug #4956: [PATCH] string.c (tr_s_bang): fix leak with heap stringshttps://bugs.ruby-lang.org/issues/4956?journal_id=188472011-07-06T04:53:09Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p>Eric Wong <a href="mailto:normalperson@yhbt.net" class="email">normalperson@yhbt.net</a> wrote:</p>
<blockquote>
<p>This also affects Ruby 1.9.2-p180</p>
</blockquote>
<p>Now this is in trunk, can we also get this backported to the 1.9.2<br>
branch? Thanks!</p> Ruby master - Bug #4956: [PATCH] string.c (tr_s_bang): fix leak with heap stringshttps://bugs.ruby-lang.org/issues/4956?journal_id=188492011-07-06T05:59:07Ztenderlovemaking (Aaron Patterson)tenderlove@ruby-lang.org
<ul><li><strong>ruby -v</strong> changed from <i>ruby 1.9.3dev (2011-07-01 trunk 32347) [x86_64-linux]</i> to <i>-</i></li></ul><p>On Wed, Jul 06, 2011 at 04:46:44AM +0900, Eric Wong wrote:</p>
<blockquote>
<p>Eric Wong <a href="mailto:normalperson@yhbt.net" class="email">normalperson@yhbt.net</a> wrote:</p>
<blockquote>
<p>This also affects Ruby 1.9.2-p180</p>
</blockquote>
<p>Now this is in trunk, can we also get this backported to the 1.9.2<br>
branch? Thanks!</p>
</blockquote>
<p>I suggest opening a backport ticket to ease yugui's job:</p>
<p><a href="http://redmine.ruby-lang.org/projects/ruby-192/issues?set_filter=1&tracker_id=4" class="external">http://redmine.ruby-lang.org/projects/ruby-192/issues?set_filter=1&tracker_id=4</a></p>
<p>--<br>
Aaron Patterson<br>
<a href="http://tenderlovemaking.com/" class="external">http://tenderlovemaking.com/</a></p> Ruby master - Bug #4956: [PATCH] string.c (tr_s_bang): fix leak with heap stringshttps://bugs.ruby-lang.org/issues/4956?journal_id=188502011-07-06T06:53:11Znormalperson (Eric Wong)normalperson@yhbt.net
<ul></ul><p>Aaron Patterson <a href="mailto:aaron@tenderlovemaking.com" class="email">aaron@tenderlovemaking.com</a> wrote:</p>
<blockquote>
<p>I suggest opening a backport ticket to ease yugui's job:</p>
<p><a href="http://redmine.ruby-lang.org/projects/ruby-192/issues?set_filter=1&tracker_id=4" class="external">http://redmine.ruby-lang.org/projects/ruby-192/issues?set_filter=1&tracker_id=4</a></p>
</blockquote>
<p>I've considered opening backport tickets in the past, but<br>
<a href="http://redmine.ruby-lang.org/projects/ruby-192" class="external">http://redmine.ruby-lang.org/projects/ruby-192</a> says:</p>
<p>"Don't report issues here"</p>
<p>--<br>
Eric Wong</p> Ruby master - Bug #4956: [PATCH] string.c (tr_s_bang): fix leak with heap stringshttps://bugs.ruby-lang.org/issues/4956?journal_id=188542011-07-06T07:23:12Ztenderlovemaking (Aaron Patterson)tenderlove@ruby-lang.org
<ul></ul><p>On Wed, Jul 06, 2011 at 06:29:24AM +0900, Eric Wong wrote:</p>
<blockquote>
<p>Aaron Patterson <a href="mailto:aaron@tenderlovemaking.com" class="email">aaron@tenderlovemaking.com</a> wrote:</p>
<blockquote>
<p>I suggest opening a backport ticket to ease yugui's job:</p>
<p><a href="http://redmine.ruby-lang.org/projects/ruby-192/issues?set_filter=1&tracker_id=4" class="external">http://redmine.ruby-lang.org/projects/ruby-192/issues?set_filter=1&tracker_id=4</a></p>
</blockquote>
<p>I've considered opening backport tickets in the past, but<br>
<a href="http://redmine.ruby-lang.org/projects/ruby-192" class="external">http://redmine.ruby-lang.org/projects/ruby-192</a> says:</p>
<p>"Don't report issues here"</p>
</blockquote>
<p>Ya, I think that should be worded like "Don't report bugs here" or<br>
something. Whenever I commit things that need to be backported, I file<br>
a ticket there so yugui knows the revisions I want backported so that<br>
she doesn't have to review every commit to trunk.</p>
<p>--<br>
Aaron Patterson<br>
<a href="http://tenderlovemaking.com/" class="external">http://tenderlovemaking.com/</a></p>