Backport #4980: rbinstall.rb will not install command scripts if the path contains a hidden directory

• Status: Rejected
• Assignee: -

[michas (Michael Schnupp)]

I tried to compile and install ruby from a longish path containing a hidden directory somewhere in the middle of the path.

While installing the "command scripts" rbinstall.rb containts the following line:
next if //[.#]|(.(old|bak|orig|rej|diff|patch|core)|~|/core)$/i =~ src

The first part of the regex should probably only match on the basename of the file to install. But as src contains the absolute path of the file it will match all files if the path contains a hidden directory somewhere. (Which it did in my case.)

I currently pached it with a small sed-script:
sed -i 's=[.#]|=[.#][^\\\/]$|=' ruby/tool/rbinstall.rb

But the nicer solution is probably to match on the basename only.

[nobu (Nobuyoshi Nakada)]

• Tracker changed from Bug to Backport
• Project changed from Ruby master to Backport192

fixed by r28134.

[spastorino (Santiago Pastorino)]

I'm hitting the same issue, installing Ruby to a .directory and in the dest bin don't have "command scripts"

[drbrain (Eric Hodel)]

This also affects multiruby

[naruse (Yui NARUSE)]

• Status changed from Open to Rejected