Project

General

Profile

Actions

Backport #5518

closed

Please backport r33577 (mingw: append -fno-omit-frame-pointer)

Added by luislavena (Luis Lavena) about 13 years ago. Updated almost 13 years ago.

Status:
Closed
[ruby-core:40533]

Description

Please backport r33577 from trunk, which solves Bug #5407 and Bug #5375.

Thank you.


Related issues 2 (0 open2 closed)

Related to Ruby master - Bug #5407: Cannot build ruby-1.9.3-rc1 with TDM-GCC 4.6.1 on Windows XP SP3Closednobu (Nobuyoshi Nakada)10/05/2011Actions
Related to Ruby master - Bug #5375: [mingw32] segfault on WinXP SP3 with 1.9.3dev@33347Closedluislavena (Luis Lavena)09/28/2011Actions

Updated by luislavena (Luis Lavena) almost 13 years ago

Hello,

Anyone can take a look to this and let me know? For convenience and review, the following is the patch I want to backport:

diff --git a/ChangeLog b/ChangeLog
index e787db4..bf77758 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@

    • Backport r33577 from trunk
    • configure.in: check -fno-omit-frame-pointer acceptance and usage
  • under MinGW. [ruby-core:39957] [Bug #5407]
    

Thu Dec 15 10:44:54 2011 Nobuyoshi Nakada

* array.c (rb_ary_reject_bang, rb_ary_delete_if): update rdoc.

diff --git a/configure.in b/configure.in
index b6c93ef..6bcd1e9 100644
--- a/configure.in
+++ b/configure.in
@@ -503,6 +503,12 @@ if test "$GCC" = yes; then
test "$visibility_option" = no || OBJCOPY=:
fi

+if test "$GCC" = yes; then

  • AS_CASE(["$target_os"], [mingw*], [
  • RUBY_TRY_CFLAGS(-fno-omit-frame-pointer, [optflags="${optflags+$optflags }-fno-omit-frame-pointer"])
  • ])
    +fi

test -z "${ac_env_CFLAGS_set}" -a -n "${cflags+set}" && eval CFLAGS=""$cflags $ARCH_FLAG""
test -z "${ac_env_CXXFLAGS_set}" -a -n "${cxxflags+set}" && eval CXXFLAGS=""$cxxflags $ARCH_FLAG""

Nobu, Usa, what do you think?

Thank you.

Updated by kosaki (Motohiro KOSAKI) almost 13 years ago

  • Subject changed from Please backport r33577 from trunk to Please backport r33577 (mingw: append -fno-omit-frame-pointer)

Updated by kosaki (Motohiro KOSAKI) almost 13 years ago

  • Status changed from Open to Closed

r34189

Actions

Also available in: Atom PDF

Like0
Like0Like0Like0