Project

General

Profile

Backport #5665

[PATCH] io.c (rb_io_fsync,rb_io_fdatasync): release GVL

Added by normalperson (Eric Wong) almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:41247]

Description

fsync() and fdatasync() may take a long time on slow disks and/or
if there is much dirty data.

Also pullable via git: git pull git://bogomips.org/ruby.git fsync-nogvl

(Once in a while I'll actually care to fsync(), most of the time I can't
stand it and even use libeatmydata :)


Files

Associated revisions

Revision ea0ef6af
Added by kosaki (Motohiro KOSAKI) almost 8 years ago

merge revision(s) r33826:

    * io.c (rb_io_fsync,rb_io_fdatasync): release GVL during fsync().
      fsync() and fdatasync() may take a long time on slow disks and/or
      if there is much dirty data.
      Patch by Eric Wong. [Feature #5665] [ruby-core:41247]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@34451 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 34451
Added by kosaki (Motohiro KOSAKI) almost 8 years ago

merge revision(s) r33826:

* io.c (rb_io_fsync,rb_io_fdatasync): release GVL during fsync().
  fsync() and fdatasync() may take a long time on slow disks and/or
  if there is much dirty data.
  Patch by Eric Wong. [Feature #5665] [ruby-core:41247]

History

Updated by kosaki (Motohiro KOSAKI) almost 8 years ago

  • Status changed from Open to Assigned
  • Assignee set to kosaki (Motohiro KOSAKI)

Looks reasonable. I'll commit it.

#3

Updated by kosaki (Motohiro KOSAKI) almost 8 years ago

  • Tracker changed from Feature to Backport
  • Project changed from Ruby master to Backport193
  • Category deleted (core)
  • Assignee changed from kosaki (Motohiro KOSAKI) to yugui (Yuki Sonoda)
  • Target version deleted (2.0.0)
#4

Updated by kosaki (Motohiro KOSAKI) almost 8 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34451.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) r33826:

* io.c (rb_io_fsync,rb_io_fdatasync): release GVL during fsync().
  fsync() and fdatasync() may take a long time on slow disks and/or
  if there is much dirty data.
  Patch by Eric Wong. [Feature #5665] [ruby-core:41247]

Also available in: Atom PDF