Project

General

Profile

This project is closed and read-only.

Actions
Copy link

Backport #5665

closed

[PATCH] io.c (rb_io_fsync,rb_io_fdatasync): release GVL

Backport #5665: [PATCH] io.c (rb_io_fsync,rb_io_fdatasync): release GVL

Added by normalperson (Eric Wong) almost 15 years ago. Updated over 14 years ago.

Status:
Closed
Assignee:
yugui (Yuki Sonoda)
[ruby-core:41247]

Description

fsync() and fdatasync() may take a long time on slow disks and/or
if there is much dirty data.

Also pullable via git: git pull git://bogomips.org/ruby.git fsync-nogvl

(Once in a while I'll actually care to fsync(), most of the time I can't
stand it and even use libeatmydata :)

Files

0001-io.c-rb_io_fsync-rb_io_fdatasync-release-GVL.patch (1.52 KB) 0001-io.c-rb_io_fsync-rb_io_fdatasync-release-GVL.patch normalperson (Eric Wong), 11/23/2011 07:50 PM

Updated by kosaki (Motohiro KOSAKI) almost 15 years ago Actions
Copy link
 #1 [ruby-core:41257]

  • Status changed from Open to Assigned
  • Assignee set to kosaki (Motohiro KOSAKI)

Looks reasonable. I'll commit it.

Updated by kosaki (Motohiro KOSAKI) almost 15 years ago Actions
Copy link
 #3

  • Tracker changed from Feature to Backport
  • Project changed from Ruby to 13
  • Category deleted (core)
  • Assignee changed from kosaki (Motohiro KOSAKI) to yugui (Yuki Sonoda)
  • Target version deleted (2.0.0)

Updated by kosaki (Motohiro KOSAKI) over 14 years ago Actions
Copy link
 #4

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34451.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

merge revision(s) r33826:

* io.c (rb_io_fsync,rb_io_fdatasync): release GVL during fsync().
  fsync() and fdatasync() may take a long time on slow disks and/or
  if there is much dirty data.
  Patch by Eric Wong. [Feature #5665] [ruby-core:41247]
Actions
Copy link

Also available in: PDF Atom