Project

General

Profile

Actions

Backport #5665

closed

[PATCH] io.c (rb_io_fsync,rb_io_fdatasync): release GVL

Added by normalperson (Eric Wong) over 12 years ago. Updated about 12 years ago.

Status:
Closed
[ruby-core:41247]

Description

fsync() and fdatasync() may take a long time on slow disks and/or
if there is much dirty data.

Also pullable via git: git pull git://bogomips.org/ruby.git fsync-nogvl

(Once in a while I'll actually care to fsync(), most of the time I can't
stand it and even use libeatmydata :)


Files

Updated by kosaki (Motohiro KOSAKI) over 12 years ago

  • Status changed from Open to Assigned
  • Assignee set to kosaki (Motohiro KOSAKI)

Looks reasonable. I'll commit it.

Actions #3

Updated by kosaki (Motohiro KOSAKI) over 12 years ago

  • Tracker changed from Feature to Backport
  • Project changed from Ruby master to Backport193
  • Category deleted (core)
  • Assignee changed from kosaki (Motohiro KOSAKI) to yugui (Yuki Sonoda)
  • Target version deleted (2.0.0)
Actions #4

Updated by kosaki (Motohiro KOSAKI) about 12 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34451.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) r33826:

* io.c (rb_io_fsync,rb_io_fdatasync): release GVL during fsync().
  fsync() and fdatasync() may take a long time on slow disks and/or
  if there is much dirty data.
  Patch by Eric Wong. [Feature #5665] [ruby-core:41247]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0