Project

General

Profile

Actions

Backport #5984

closed

Pathname binread test is testing read

Added by Eregon (Benoit Daloze) about 12 years ago. Updated about 12 years ago.

Status:
Closed
Assignee:
-
[ruby-core:42440]

Description

Hello,

I noticed the 'binread' test in test/pathname/test_pathname.rb calls read instead of binread:

diff --git a/test/pathname/test_pathname.rb b/test/pathname/test_pathname.rb
index dcbcd49..1631403 100644
--- a/test/pathname/test_pathname.rb
+++ b/test/pathname/test_pathname.rb
@@ -710,7 +710,7 @@ class TestPathname < Test::Unit::TestCase
def test_binread
with_tmpchdir('rubytest-pathname') {|dir|
open("a", "w") {|f| f.write "abc" }

  •  assert_equal("abc", Pathname("a").read)
    
  •  assert_equal("abc", Pathname("a").binread)
    
    }
    end
Actions #1

Updated by naruse (Yui NARUSE) about 12 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r34499.
Benoit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • test/pathname/test_pathname.rb: not read but binread.
    patched by Benoit Daloze, [ruby-core:42440] [Bug #5984]
Actions #2

Updated by naruse (Yui NARUSE) about 12 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport193
  • Category deleted (lib)
  • Target version deleted (2.0.0)
Actions

Also available in: Atom PDF

Like0
Like0Like0