Backport #6052: please add vendorarchdir and vendorlibdir to ruby.pc

• Status: Closed
• Assignee: -

[ellson (John Ellson)]

(originally reported in: https://bugzilla.redhat.com/show_bug.cgi?id=789532
this issue separates the issue of vendorarchdir from the ruby-1.9.pc -> ruby.pc renaming issue).

[John Ellson]
The current ruby-1.9.pc doesn't provide a value for "vendorarchdir"
and so is insufficient for packages like graphviz to build ruby extensions
without still resorting to ruby's (ever changing) RbConfig (nee: Config)
mechanism.

[Bohuslav "Slavek" Kabrda]

• Defining vendorarchdir and vendorlibdir is not a problem but how would it
  solve the problem with graphviz? And how would you propose to use these -
  passing them as additional Cflags?

[John Ellson]
No, not Cflags. The value is need for installation, not compilation.

Assuming ruby.pc contains a line like:
vendorarchdir=${libdir}/ruby/vendor_ruby

configure.ac would extract it by using something like:
PKG_CHECK_MODULES(RUBY, [ruby >= 1.9],[
RUBY_INSTALL_DIR=pkg-config --variable vendorarchdir ruby
AC_SUBST([RUBY_INSTALL_DIR])
],[
#deal with pre 1.9 ruby's
])

[nobu (Nobuyoshi Nakada)]

• Tracker changed from Bug to Feature

[nobu (Nobuyoshi Nakada)]

• Status changed from Open to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r34716.
John, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• template/ruby.pc.in: added rubylibprefix, {rubylib,vendor,site}dir
  and {ruby,vendor,site}archdir. [ruby-core:42766][Feature #6052]

Hi, I'm finding it really hard to follow some of the changes that you have done here. I'm not implying that anything is wrong, maybe I don't get something, so please take this rather as a question, but the settings you now provide in ruby.pc are not well for Fedora (I don't know about other platforms, but let me explain):

Current state:

rubylibprefix=@rubylibprefix@
rubylibdir=${rubylibprefix}/${ruby_version}
vendordir=${rubylibprefix}/vendor_ruby
sitedir=${rubylibprefix}/site_ruby
rubyarchdir=${rubylibdir}/${arch}
vendorarchdir=${vendordir}/${sitearch}
sitearchdir=${sitedir}/${sitearch}

The problem is that vendorarchdir gets translated to ${rubylibprefix}/vendor_ruby/${sitearch}, which then gets translated to /usr/share/ruby/vendor_ruby/${sitearch}, which seems wrong (platform specific files get under /usr/share) - it should be /usr/lib[64]/ruby/vendor_ruby, so something like %{libdir}/vendor_ruby, shouldn't it?

Am I missing something or is this really an issue? If so, would it be possible to backport it to 1.9.3 branch?

Thank you!

[nobu (Nobuyoshi Nakada)]

rubylibprefix isn't under datarootdir by default, unless you change it by yourself.

Yes, that is true. I however miss the point of having vendordir and vendorarchdir under the same directory, whatever it is.

[nobu (Nobuyoshi Nakada)]

see #6111.

Yes, having something like the feature requested in #6111 would be the thing I'm looking for (the important part is, that vendorarchdir doesn't get under vendordir, as it is now).

[vo.x (Vit Ondruch)]

Would you mind to backport this into 1.9.3? Thank you.

[kosaki (Motohiro KOSAKI)]

• Tracker changed from Feature to Backport
• Project changed from Ruby master to Backport193
• Status changed from Closed to Open

[naruse (Yui NARUSE)]

• Status changed from Open to Closed

This issue was solved with changeset r36561.
John, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

merge revision(s) 34716:

* template/ruby.pc.in: added rubylibprefix, {rubylib,vendor,site}dir
  and {ruby,vendor,site}archdir.  [ruby-core:42766][Feature #6052]