Project

General

Profile

Actions

Backport #6295

closed

Please backport r35296 (textmode File#read on CRLF)

Added by h.shirosaki (Hiroshi Shirosaki) about 12 years ago. Updated about 12 years ago.

Status:
Closed
Assignee:
-
[ruby-core:44359]

Description

Backport request for #6271. (textmode File#read on CRLF)

Revision is r35296

1.9.3p125 has this bug. Backport would be better.

Actions #1

Updated by naruse (Yui NARUSE) about 12 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r35331.
Hiroshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 35296: [Backport #6295]

* io.c (rb_io_eof): use eof() instead of io_fillbuf(). It's because
  io_unread() doesn't work properly when reading CRLF with read(length)
  and mode 'r'.
  [ruby-core:44189][Bug #6271]

* test/ruby/test_io_m17n.rb (TestIO_M17N#test_read_crlf_and_eof):
  test for above.
Actions

Also available in: Atom PDF

Like0
Like0