Backport #6402

backport fixes for [ruby-core:44755]

Added by Aaron Patterson over 3 years ago. Updated over 3 years ago.

[ruby-core:44879]
Status:Closed
Priority:Normal
Assignee:Aaron Patterson

Description

Hi, we should backport the changes for to the 1.9.3 branch. I've attached a patch. Can someone (nobu or martin) please review and I'll apply to the 1.9.3 branch?

Thanks!

ssl_fixes.patch Magnifier (1.81 KB) Aaron Patterson, 05/05/2012 08:13 AM

History

#1 Updated by Evan Phoenix over 3 years ago

Looks good to me! A lot of people are hitting this now, so we should backport it.

--
Evan Phoenix // evan@phx.io

On Friday, May 4, 2012 at 4:13 PM, tenderlovemaking (Aaron Patterson) wrote:

Issue #6402 has been reported by tenderlovemaking (Aaron Patterson).


Backport #6402: backport fixes for
https://bugs.ruby-lang.org/issues/6402

Author: tenderlovemaking (Aaron Patterson)
Status: Open
Priority: Normal
Assignee:
Category:
Target version:

Hi, we should backport the changes for to the 1.9.3 branch. I've attached a patch. Can someone (nobu or martin) please review and I'll apply to the 1.9.3 branch?

Thanks!

http://bugs.ruby-lang.org/

#2 Updated by Martin Bosslet over 3 years ago

Yes, I agree, too!

#3 Updated by Martin Bosslet over 3 years ago

By the way, since there are a couple of OpenSSL-related issues floating around right now - could you please help me summarize so that I can get a better overview whether there are open issues that would need to be addressed in Ruby's OpenSSL?

Several issues seem to have turned up in https://github.com/rubygems/rubygems/issues/319. One bug was definitely related to a modification of OpenSSL itself introduced by Ubuntu 12.04 which has been fixed by now.

But regarding the problem on OS X, there seemed to be several issues causing similar but unrelated problems. There was one problem related to RubyGems server settings, which has been fixed. Were there also problems related to what nobu fixed with this patch? Are there other open issues on OS X that yet remain to be identified?

The first reactions seemed to imply that upgrading to 1.0.1 would somehow fix the issues, but I doubt it, especially in the case where certificate validation failed.

#4 Updated by Aaron Patterson over 3 years ago

  • Status changed from Open to Closed
  • Assignee set to Aaron Patterson
  • % Done changed from 0 to 100

I've committed this to the 1.9.3 branch, so I'm closing this now.

Also available in: Atom PDF