Backport #6504

mkmf.rb should not use CFLAGS when compiling C++ code

Added by Hans de Graaff almost 3 years ago. Updated almost 2 years ago.

[ruby-core:45273]
Status:Closed
Priority:Normal
Assignee:Tomoyuki Chikanaga

Description

mkmf.rb currently sets CXXFLAGS to include CFLAGS. It should not do this because CFLAGS are meant for C compilation only and may contain flags that cause problems with C++. If there are flags that are common to both C and C++ (such as the -I flags in the downstream bug) then these should be collected in a separate variable.

https://github.com/ruby/ruby/blob/trunk/lib/mkmf.rb#L1786

CXXFLAGS = $(CFLAGS) #{CONFIG['CXXFLAGS']}

For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281


Related issues

Related to Ruby trunk - Bug #8315: mkmf does not include include paths from pkg_config anymore Closed 04/24/2013

Associated revisions

Revision 39994
Added by Nobuyoshi Nakada almost 2 years ago

mkmf.rb: no CFLAGS in CXXFLAGS

  • lib/mkmf.rb (configuration): not include all CFLAGS in CXXFLAGS, to use different set than C for C++. [Bug #6504]

Revision 40291
Added by Tomoyuki Chikanaga almost 2 years ago

merge revision(s) 39994: [Backport #6504]

* lib/mkmf.rb (configuration): not include all CFLAGS in CXXFLAGS, to
  use different set than C for C++.   [Bug #6504]

History

#1 Updated by Yusuke Endoh almost 3 years ago

  • Assignee set to Nobuyoshi Nakada
  • Status changed from Open to Assigned

#2 Updated by Nobuyoshi Nakada almost 3 years ago

  • Status changed from Assigned to Feedback

hansdegraaff (Hans de Graaff) wrote:

For reference our downstream bug report that triggered this: https://bugs.gentoo.org/show_bug.cgi?id=396281

I can't see that page because of "untrusted issuer error".

#3 Updated by Eric Hodel about 2 years ago

  • Subject changed from mkrf.rb should not use CFLAGS when compiling C++ code to mkmf.rb should not use CFLAGS when compiling C++ code
  • Status changed from Feedback to Rejected

Since the submitter has not given access to the downstream bug report as requested I am rejecting this.

#4 Updated by Hal Brodigan almost 2 years ago

Visiting https://bugs.gentoo.org/ gives me "Error code: sec_error_untrusted_issuer)" with Firefox 19 on Fedora 17. I can however add an exception and temporarily trust the certificate in order to view the bug report.

#5 Updated by Diego Elio Petten├▓ almost 2 years ago

It's not like the bug at Gentoo adds much more. It just happens to be somebody who has different CFLAGS/CXXFLAGS (like many do, for instance it's common to use -ggdb3 on C code, but not enabling it on C++ code because it requires at least an order of magnitude more ram), and gets fxruby built with the wrong set.

How much more info than this (which was provided in the original report, including the reference to the line where the mix-up is happening) do you expect? An essay on why you should not mix flags for one language with those for another? A dissertation on why any half-serious build system, including both Autotools and CMake, keep the two separate?

#6 Updated by Eric Hodel almost 2 years ago

  • Status changed from Rejected to Assigned

#7 Updated by Nobuyoshi Nakada almost 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39994.
Hans, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


mkmf.rb: no CFLAGS in CXXFLAGS

  • lib/mkmf.rb (configuration): not include all CFLAGS in CXXFLAGS, to use different set than C for C++. [Bug #6504]

#8 Updated by Nobuyoshi Nakada almost 2 years ago

  • Project changed from Ruby trunk to Backport200
  • Tracker changed from Bug to Backport
  • Status changed from Closed to Assigned
  • Assignee changed from Nobuyoshi Nakada to Tomoyuki Chikanaga

#9 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40291.
Hans, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39994: [Backport #6504]

* lib/mkmf.rb (configuration): not include all CFLAGS in CXXFLAGS, to
  use different set than C for C++.   [Bug #6504]

#10 Updated by Tomoyuki Chikanaga 6 months ago

  • Related to Bug #8315: mkmf does not include include paths from pkg_config anymore added

Also available in: Atom PDF