Project

General

Profile

Backport #6516

Backport Zlib::Inflate#set_dictionary API fix

Added by igrigorik (Ilya Grigorik) about 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
[ruby-core:<unknown>]

Description

As #5929 documented, the current API for Zlib::Inflate#set_dictionary is broken in 1.9.x. The fix has been committed by Eric but is targeted for 2.0.0 only at the moment.

Could we backport this to 1.9.x branch? We need dictionary support to enable SPDY without relying on other native gems.

Associated revisions

Revision b3e306a5
Added by naruse (Yui NARUSE) about 7 years ago

merge revision(s) 34552: [Bug #6516]

    * ext/zlib/zlib.c (do_inflate):  Inflate more data if buffered data
      exists.  Allows Zlib::Inflate#set_dictionary to work.
      [ruby-trunk - Bug #5929]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@35845 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 35845
Added by naruse (Yui NARUSE) about 7 years ago

merge revision(s) 34552: [Bug #6516]

* ext/zlib/zlib.c (do_inflate):  Inflate more data if buffered data
  exists.  Allows Zlib::Inflate#set_dictionary to work.
  [ruby-trunk - Bug #5929]

Revision 898b9c1b
Added by naruse (Yui NARUSE) about 7 years ago

merge revision(s) 34552: [Backport #6516]

    * ext/zlib/zlib.c (do_inflate):  Inflate more data if buffered data
      exists.  Allows Zlib::Inflate#set_dictionary to work.
      [ruby-trunk - Bug #5929]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@36223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 36223
Added by naruse (Yui NARUSE) about 7 years ago

merge revision(s) 34552: [Backport #6516]

* ext/zlib/zlib.c (do_inflate):  Inflate more data if buffered data
  exists.  Allows Zlib::Inflate#set_dictionary to work.
  [ruby-trunk - Bug #5929]

History

#1

Updated by mame (Yusuke Endoh) about 7 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport193
#2

Updated by naruse (Yui NARUSE) about 7 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r36223.
Ilya, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 34552: [Backport #6516]

* ext/zlib/zlib.c (do_inflate):  Inflate more data if buffered data
  exists.  Allows Zlib::Inflate#set_dictionary to work.
  [ruby-trunk - Bug #5929]

Also available in: Atom PDF