https://bugs.ruby-lang.org/
https://bugs.ruby-lang.org/favicon.ico?1711330511
2012-07-21T22:40:52Z
Ruby Issue Tracking System
Ruby master - Bug #6765: test_filename_utf8_raw_name and test_filename_euc_jp (test_dir_m17n.rb) fail on non-JapaneseWindows
https://bugs.ruby-lang.org/issues/6765?journal_id=28254
2012-07-21T22:40:52Z
luislavena (Luis Lavena)
luislavena@gmail.com
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Feedback</i></li></ul><p>=begin<br>
Thank you Oleg for the patch.</p>
<p>I just tested it, but still have a failure:</p>
<p>Before patch:</p>
<a name="Running-tests"></a>
<h1 >Running tests:<a href="#Running-tests" class="wiki-anchor">¶</a></h1>
<p>[ 4/10] TestDir_M17N#test_filename_euc_jp = 0.08 s</p>
<ol>
<li>Failure:<br>
test_filename_euc_jp(TestDir_M17N) [C:/Users/Worker/Code/ruby/ruby/test/ruby/test_dir_m17n.rb:170]:<br>
ruby exit status is not success: #<Process::Status: pid 4500 exit 1></li>
</ol>
<p>[ 9/10] TestDir_M17N#test_filename_utf8_raw_name = 0.08 s<br>
2) Failure:<br>
test_filename_utf8_raw_name(TestDir_M17N) [C:/Users/Worker/Code/ruby/ruby/test/ruby/test_dir_m17n.rb:190]:<br>
ruby exit status is not success: #<Process::Status: pid 6892 exit 1></p>
<p>Finished tests in 0.657084s, 15.2188 tests/s, 27.3938 assertions/s.<br>
10 tests, 18 assertions, 2 failures, 0 errors, 0 skips</p>
<p>ruby -v: ruby 2.0.0dev (2012-07-21 trunk 36486) [i386-mingw32]</p>
<p>After patch:</p>
<a name="Running-tests-2"></a>
<h1 >Running tests:<a href="#Running-tests-2" class="wiki-anchor">¶</a></h1>
<p>[ 4/12] TestDir_M17N#test_filename_euc_jp = 0.08 s</p>
<ol>
<li>Failure:<br>
test_filename_euc_jp(TestDir_M17N) [C:/Users/Worker/Code/ruby/ruby/test/ruby/test_dir_m17n.rb:196]:<br>
ruby exit status is not success: #<Process::Status: pid 6596 exit 1></li>
</ol>
<p>Finished tests in 0.809603s, 14.8221 tests/s, 27.1738 assertions/s.<br>
12 tests, 22 assertions, 1 failures, 0 errors, 0 skips</p>
<p>ruby -v: ruby 2.0.0dev (2012-07-21 trunk 36486) [i386-mingw32]</p>
<p>Seems like (({test_filename_euc_jp})) is still failing.</p>
<p>My codepage is 1252, changing it to 1251 seems to solve the issue, which indicate some minor issue with this test.</p>
<p>Can you confirm with chcp 1252?</p>
<p>Thank you.<br>
=end</p>
Ruby master - Bug #6765: test_filename_utf8_raw_name and test_filename_euc_jp (test_dir_m17n.rb) fail on non-JapaneseWindows
https://bugs.ruby-lang.org/issues/6765?journal_id=28259
2012-07-22T00:30:37Z
os97673 (Oleg Sukhodolsky)
os97673@gmail.com
<ul><li><strong>File</strong> <a href="/attachments/2925">test_dir_m17n.rb.v2.diff</a> <a class="icon-only icon-download" title="Download" href="/attachments/download/2925/test_dir_m17n.rb.v2.diff">test_dir_m17n.rb.v2.diff</a> added</li></ul><p>The patch updated to make test_filename_euc_jp pass on Windows-1252.</p>
Ruby master - Bug #6765: test_filename_utf8_raw_name and test_filename_euc_jp (test_dir_m17n.rb) fail on non-JapaneseWindows
https://bugs.ruby-lang.org/issues/6765?journal_id=28260
2012-07-22T00:33:23Z
luislavena (Luis Lavena)
luislavena@gmail.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Assigned</i></li><li><strong>Target version</strong> set to <i>2.0.0</i></li></ul><p>=begin<br>
Thank you Oleg,</p>
<p>I can confirm new patch works:</p>
<a name="Running-tests"></a>
<h1 >Running tests:<a href="#Running-tests" class="wiki-anchor">¶</a></h1>
<p>Finished tests in 0.785099s, 15.2847 tests/s, 28.0219 assertions/s.<br>
12 tests, 22 assertions, 0 failures, 0 errors, 0 skips</p>
<p>ruby -v: ruby 2.0.0dev (2012-07-21 trunk 36486) [i386-mingw32]</p>
<p>Nobu, Usa, can I commit?</p>
<p>Any with Japanese-Windows to double check?</p>
<p>Thank you<br>
=end</p>
Ruby master - Bug #6765: test_filename_utf8_raw_name and test_filename_euc_jp (test_dir_m17n.rb) fail on non-JapaneseWindows
https://bugs.ruby-lang.org/issues/6765?journal_id=28359
2012-07-24T08:32:31Z
luislavena (Luis Lavena)
luislavena@gmail.com
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r36509.<br>
Oleg, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<p>Fix raw UTF-8 test for non-Japanase Windows systems</p>
<ul>
<li>
<p>test/ruby/test_dir_m17n.rb (create_and_check_raw_file_name): add new<br>
helper method to ease encoding testing. Patch by Oleg Sukhodolsky.<br>
<a href="/issues/6765">[ruby-core:46589]</a>[Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: test_filename_utf8_raw_name and test_filename_euc_jp (test_dir_m17n.rb) fail on non-JapaneseWindows (Closed)" href="https://bugs.ruby-lang.org/issues/6765">#6765</a>]</p>
</li>
<li>
<p>test/ruby/test_dir_m17n.rb (test_filename_extutf8): use filesystem<br>
encoding when reading entries and comparing.</p>
</li>
<li>
<p>test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_name): removed.</p>
</li>
<li>
<p>test/ruby/test_dir_m17n.rb (test_filename_utf8_raw_jp_name): split test.</p>
</li>
</ul>