Project

General

Profile

Backport #6772

curses: support linking against pdcurses

Added by luislavena (Luis Lavena) over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal

Description

Hello,

On Windows, ncurses are not available. Instead we link against PDCurses when building RubyInstaller.

Except that we required rename linking library to libcurses so curses extension finds it.

I would like to ask curses extension supports pdcurses linking library.

Attached is a patch that allows linking against unmodified pdcurses linking library.

I would like to port this change also to 1.9.3 in order to standardize building RubyInstaller.

Thank you


Files

ext-curses-accept-pdcurses.diff (600 Bytes) ext-curses-accept-pdcurses.diff luislavena (Luis Lavena), 07/22/2012 11:22 PM

Associated revisions

Revision 33d5c484
Added by naruse (Yui NARUSE) over 7 years ago

merge revision(s) 36455: [Backport #6772]

    * ext/curses/extconf.rb: support PDCurses.  patched by Luis Lavena.
      [ruby-core:46485] [Feature #6735]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@36564 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 36564
Added by naruse (Yui NARUSE) over 7 years ago

merge revision(s) 36455: [Backport #6772]

* ext/curses/extconf.rb: support PDCurses.  patched by Luis Lavena.
  [ruby-core:46485] [Feature #6735]

History

#1

Updated by luislavena (Luis Lavena) over 7 years ago

Hello,

Please backport r36436 from trunk into ruby_1_9_3

Due differences in code, I took the liberty to provide a patch for it (attached)

Let me know if is OK with you and I can apply.

Thank you.

Updated by luislavena (Luis Lavena) over 7 years ago

  • % Done changed from 100 to 0
#4

Updated by naruse (Yui NARUSE) over 7 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r36564.
Luis, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 36455: [Backport #6772]

* ext/curses/extconf.rb: support PDCurses.  patched by Luis Lavena.
  [ruby-core:46485] [Feature #6735]

Also available in: Atom PDF