Project

General

Profile

Backport #6846

Please backport Feature #6845

Added by jonforums (Jon Forums) over 7 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
[ruby-core:47090]

Description

Please backport #6845 in time for the next 1.9.3 release.

As Hiroshi mentioned, we've successfully included DuĊĦan's original patch in TCS Ruby 1.9.3 releases for many months with no reported issues.

Thank you, Jon


Files

backport_stat.patch (4.77 KB) backport_stat.patch h.shirosaki (Hiroshi Shirosaki), 08/21/2012 09:05 AM

Related issues

Related to Ruby master - Feature #6845: Optimize stat on WindowsClosed08/09/2012Actions

Associated revisions

Revision 8433e20f
Added by naruse (Yui NARUSE) about 7 years ago

merge revision(s) 36668: [Backport #6846]

    * test/ruby/test_file_exhaustive.rb
      (TestFileExhaustive#test_stat_special_file): add a test.
      GetFileAttributesExW fails to get attributes of special files
      such as pagefile.sys.

    * win32/win32.c (check_valid_dir): for performance, check the path
      by FindFirstFileW only if the path contains "...".

    * win32/win32.c (winnt_stat): use GetFileAttributesExW instead of
      FindFirstFileW since GetFileAttributesExW is faster.
      Based on the patch by Dusan D. Majkic.
      [ruby-core:47083] [Feature #6845]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@36792 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 36792
Added by naruse (Yui NARUSE) about 7 years ago

merge revision(s) 36668: [Backport #6846]

* test/ruby/test_file_exhaustive.rb
  (TestFileExhaustive#test_stat_special_file): add a test.
  GetFileAttributesExW fails to get attributes of special files
  such as pagefile.sys.

* win32/win32.c (check_valid_dir): for performance, check the path
  by FindFirstFileW only if the path contains "...".

* win32/win32.c (winnt_stat): use GetFileAttributesExW instead of
  FindFirstFileW since GetFileAttributesExW is faster.
  Based on the patch by Dusan D. Majkic.
  [ruby-core:47083] [Feature #6845]

History

Updated by naruse (Yui NARUSE) about 7 years ago

  • Status changed from Open to Feedback

The change won't be merged to 1.9.3 without conflict.

Updated by jonforums (Jon Forums) about 7 years ago

Are you OK with merging the change if one of us provides a no-conflict patch based upon ruby_1_9_3@36735?

Updated by h.shirosaki (Hiroshi Shirosaki) about 7 years ago

I resolved conflicts.
make, make test, make test-all look fine with mingw32 build on Win7.

#4

Updated by naruse (Yui NARUSE) about 7 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r36792.
Jon, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 36668: [Backport #6846]

* test/ruby/test_file_exhaustive.rb
  (TestFileExhaustive#test_stat_special_file): add a test.
  GetFileAttributesExW fails to get attributes of special files
  such as pagefile.sys.

* win32/win32.c (check_valid_dir): for performance, check the path
  by FindFirstFileW only if the path contains "...".

* win32/win32.c (winnt_stat): use GetFileAttributesExW instead of
  FindFirstFileW since GetFileAttributesExW is faster.
  Based on the patch by Dusan D. Majkic.
  [ruby-core:47083] [Feature #6845]

Also available in: Atom PDF