https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112012-11-05T21:44:55ZRuby Issue Tracking SystemRuby master - Bug #7161: Perf fix: use symbols instead of strings for const/ivar access methodshttps://bugs.ruby-lang.org/issues/7161?journal_id=324052012-11-05T21:44:55Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>shyouhei (Shyouhei Urabe)</i></li></ul><p>The patch looks benign. I wonder how much is the performance improved, though.<br>
Urabe-san, could you handle the pull request?</p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a></p> Ruby master - Bug #7161: Perf fix: use symbols instead of strings for const/ivar access methodshttps://bugs.ruby-lang.org/issues/7161?journal_id=324522012-11-06T02:38:55Zheadius (Charles Nutter)headius@headius.com
<ul></ul><p>The performance gain is not tremendous, but it does avoid a lot of intermediate string objects that could cumulatively impact performance through GC overhead.</p>
<p>In any case, it's a good cleanup patch, and there are certainly small perf gains.</p> Ruby master - Bug #7161: Perf fix: use symbols instead of strings for const/ivar access methodshttps://bugs.ruby-lang.org/issues/7161?journal_id=329662012-11-17T00:38:15Zheadius (Charles Nutter)headius@headius.com
<ul></ul><p>Ping!</p> Ruby master - Bug #7161: Perf fix: use symbols instead of strings for const/ivar access methodshttps://bugs.ruby-lang.org/issues/7161?journal_id=329852012-11-17T02:44:41Zmarcandre (Marc-Andre Lafortune)marcandre-ruby-core@marc-andre.ca
<ul><li><strong>Category</strong> set to <i>lib</i></li><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul><p>Committed as r37688.</p>
<p>I'm sorry, I should have added 'patch by Charles Nutter' to the commit log but I forgot that although git can track authors, svn does not.</p> Ruby master - Bug #7161: Perf fix: use symbols instead of strings for const/ivar access methodshttps://bugs.ruby-lang.org/issues/7161?journal_id=330142012-11-17T19:09:34Zheadius (Charles Nutter)headius@headius.com
<ul></ul><p>I'll forgive you this time, Marc-Andre :)</p>