Backport #7217

Race condition in build process?

Added by Vit Ondruch over 2 years ago. Updated over 2 years ago.

[ruby-core:48301]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

=begin
Hi, I observer random build failures when building 'make -j16'. I am not sure if it might be either PowerPC issue or race condition in build process.

This is error I observe:

cp: cannot create regular file '../../.ext/common/date': File exists
gcc -shared -o ../../../.ext/powerpc-linux/-test-/string/string.so enc_associate.o modify.o init.o cstr.o set_len.o ellipsize.o -L. -L../../.. -L. -Wl,-z,relro -rdynamic -Wl,-export-dynamic -m32 -lruby -lpthread -lrt -ldl -lcrypt -lm -lc
make[2]: Entering directory /builddir/build/BUILD/ruby-1.9.3-p286/ext/etc'
make[2]: Entering directory
/builddir/build/BUILD/ruby-1.9.3-p286/ext/fcntl'
make[2]: *** [../../.ext/common/date/format.rb] Error 1
make[2]: *** Waiting for unfinished jobs....

And here https://gist.github.com/3957425 is full build log.

Thank you

=end


Related issues

Duplicates Ruby trunk - Bug #6904: make -j all fails (sometimes) Closed 08/22/2012

Associated revisions

Revision 37553
Added by Usaku NAKAMURA over 2 years ago

merge revision(s) 36815,36816,36818,37414,37426,37427: [Backport #7217]

Thu Nov 8 14:16:53 2012 Nobuyoshi Nakada nobu@ruby-lang.org

* lib/mkmf.rb (MakeMakefile#timestamp_file): use .-. instead of !, a
  special character of NMAKE and BSD make.  [Bug #7265]

Thu Nov 8 14:16:53 2012 Nobuyoshi Nakada nobu@ruby-lang.org

* lib/mkmf.rb (MakeMakefile#timestamp_file): use ! instead of %, a GNU
  make special character.

Thu Nov 8 14:16:53 2012 Nobuyoshi Nakada nobu@ruby-lang.org

* lib/mkmf.rb (create_makefile): use timestamp for destination
  directories to make them before making or copying files there.
   [Bug #6904]

History

#1 Updated by Yusuke Endoh over 2 years ago

  • Status changed from Open to Assigned
  • Assignee set to Aaron Patterson

Aaron, are you one of bcrypt-ruby developers?
Do you know anything about this issue?
Looks related to: https://github.com/codahale/bcrypt-ruby/issues/46

Yusuke Endoh mame@tsg.ne.jp

#2 Updated by Yusuke Endoh over 2 years ago

  • Status changed from Assigned to Open
  • Assignee deleted (Aaron Patterson)

Oops, wrong ticket. Sorry.

#3 Updated by Yusuke Endoh over 2 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby trunk to Backport193
  • Status changed from Open to Assigned
  • Assignee set to Usaku NAKAMURA

Nobu said this is already fixed at r36815, r37414, r37426, and r37427.

Usa-san, please review them and backport to 1.9.3 if needed.

Yusuke Endoh mame@tsg.ne.jp

#4 Updated by Nobuyoshi Nakada over 2 years ago

Associated revisions are r36815, r36816, r36818, r37414, r37426, r37427.

#5 Updated by Usaku NAKAMURA over 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r37553.
Vit, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 36815,36816,36818,37414,37426,37427: [Backport #7217]

Thu Nov 8 14:16:53 2012 Nobuyoshi Nakada nobu@ruby-lang.org

* lib/mkmf.rb (MakeMakefile#timestamp_file): use .-. instead of !, a
  special character of NMAKE and BSD make.  [Bug #7265]

Thu Nov 8 14:16:53 2012 Nobuyoshi Nakada nobu@ruby-lang.org

* lib/mkmf.rb (MakeMakefile#timestamp_file): use ! instead of %, a GNU
  make special character.

Thu Nov 8 14:16:53 2012 Nobuyoshi Nakada nobu@ruby-lang.org

* lib/mkmf.rb (create_makefile): use timestamp for destination
  directories to make them before making or copying files there.
   [Bug #6904]

Also available in: Atom PDF