Backport #7720

Process.daemon does not clean up background Ruby threads, leading to hang at exit

Added by Ben Weintraub over 2 years ago. Updated over 2 years ago.

[ruby-core:51549]
Status:Assigned
Priority:Normal
Assignee:Usaku NAKAMURA

Description

Process.fork appears to make special considerations for Ruby background threads so that they are cleaned up in the child process after fork (since fork() only duplicates the calling thread). Process.daemon also relies on fork internally, but does not make the same considerations, leading to a hang at exit in a daemonized process that had multiple Ruby threads prior to calling Process.daemon.

The attached daemon.rb demonstrates the issue. It will call either Process.daemon (default) or Process.fork (if you pass 'fork' as the first arg).

If you pass nothing, causing it to call Process.daemon, the daemonized Ruby process will still think it has two threads, and will hang indefinitely on exit, in a loop in rb_thread_terminate_all. If you pass 'fork' as the first argument, the forked child does not hang, and appears to have only one Ruby thread (the one that called Process.fork).

It looks like rb_thread_atfork() is the relevant call in the fork case that makes this work, but it doesn't appear to be called in the daemon case.

daemon.rb Magnifier (306 Bytes) Ben Weintraub, 01/22/2013 02:33 AM


Related issues

Duplicated by Ruby trunk - Bug #7798: 子スレッドを実行しているとき Process.daemon すると,その後メインスレッドが終了してもプロセスが終了しない Closed 02/07/2013

History

#1 Updated by Sam Goldstein over 2 years ago

This seems to be the underlying cause of the bad interaction between resque and new relic described at https://github.com/defunkt/resque/issues/578

#2 Updated by Koichi Sasada over 2 years ago

Does this issue remain on trunk?
(Should we modify trunk before 2.0?)

#3 Updated by Motohiro KOSAKI over 2 years ago

trunk doesn't have an issue. fork and daemon make the same result.

#4 Updated by Usaku NAKAMURA over 2 years ago

  • Assignee set to Usaku NAKAMURA
  • Status changed from Open to Assigned

So, what's the difference?

#5 Updated by Usaku NAKAMURA over 2 years ago

  • Project changed from Ruby trunk to Backport193
  • Tracker changed from Bug to Backport

Also available in: Atom PDF