Backport #7746

Backport NSGetEnviron()/setproctitle.c fix for macosx

Added by Christian Höltje about 1 year ago. Updated about 1 year ago.

[ruby-core:51713]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

The fix for issue #6576 should be back ported to 1.9.3 as well. Without it you cannot build shared ruby libraries that work reliably. An example of this breakage is compiling something that uses the embedded library like vim; it crashes the instance vim tries to use ruby.

Here's the patch needed:

diff --git a/missing/setproctitle.c b/missing/setproctitle.c
index 169ba8b..4dc6d03 100644
--- a/missing/setproctitle.c
+++ b/missing/setproctitle.c
@@ -48,6 +48,12 @@
#endif
#include

+#if defined(APPLE)
+#include
+#undef environ
+#define environ (NSGetEnviron())
+#endif
+
#define SPT
NONE 0 /
don't use it at all /
#define SPT_PSTAT 1 /
use pstat(PSTATSETCMD, ...) */
#define SPT
REUSEARGV 2 /* cover argv with title information */

Associated revisions

Revision 39091
Added by Usaku NAKAMURA about 1 year ago

merge revision(s) 36151: [Backport #7746]

* missing/setproctitle.c (environ): use (*_NSGetEnviron()) instead of
  environ on Darwin for namespace cleanness, same as .
   [Bug #6576]

History

#1 Updated by Motohiro KOSAKI about 1 year ago

Confused. Mac OS X has native setproctile(). I think missing/setproctitle.c shouldn't be used.

#2 Updated by Jack Nagel about 1 year ago

kosaki (Motohiro KOSAKI) wrote:

Confused. Mac OS X has native setproctile(). I think missing/setproctitle.c shouldn't be used.

At least 10.6 does not have setproctitle().

#3 Updated by Motohiro KOSAKI about 1 year ago

  • Status changed from Open to Assigned
  • Assignee changed from Motohiro KOSAKI to Usaku NAKAMURA

OK, ack then.
Usa-san, I think r36151 can be apply cleanly.

#4 Updated by Usaku NAKAMURA about 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39091.
Christian, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 36151: [Backport #7746]

* missing/setproctitle.c (environ): use (*_NSGetEnviron()) instead of
  environ on Darwin for namespace cleanness, same as .
   [Bug #6576]

Also available in: Atom PDF