Backport #7754: Backport file.c (realpath_rec) GC fix to 1.9.3

• Status: Closed
• Assignee: usa (Usaku NAKAMURA)

[jschneiderhan (Jon-Erik Schneiderhan)]

I'm hitting a problem with ruby-1.9.3-p327 and ruby-1.9.3-p374 that I tracked down with gdb to the realpath_rec method in file.c. The behavior I am seeing is that the char array pointed at by link_names is written over if GC runs in subsequent calls to realpath_rec.

It turns out the issue has already been resolved in trunk:

https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/37174/diff/file.c

I was wondering if this could be backported to 1.9.3.

[luislavena (Luis Lavena)]

• Status changed from Open to Assigned
• Assignee set to usa (Usaku NAKAMURA)

[usa (Usaku NAKAMURA)]

• Tracker changed from Bug to Backport
• Project changed from Ruby master to Backport193
• Category deleted (core)
• Target version deleted (1.9.3)

[usa (Usaku NAKAMURA)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r39092.
Jon-Erik, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

merge revision(s) 37174: [Backport #7754]

* file.c (realpath_rec): prevent link from GC while link_names refers
  the content.