Project

General

Profile

Actions

Backport #7925

closed

refine bug with puts

Added by marcandre (Marc-Andre Lafortune) about 11 years ago. Updated about 11 years ago.


Description

As reported by Dave Thomas in [ruby-core:52515]

module VanityPuts
  refine Object do
    private
    def puts(*args)
      args.each do |arg|
        super("Dave says: #{arg}")
      end
    end
  end
end

using VanityPuts

puts "Hello" # => SystemStackError, expected "Dave says: Hello"
Actions #1

Updated by nobu (Nobuyoshi Nakada) about 11 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39451.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


vm_insnhelper.c: compare with me in method top cfp

  • vm_insnhelper.c (vm_call_method): block level control frame does not
    have method entry, so obtain the method entry from method top-level
    control frame to be compared with refined method entry.
    [ruby-core:52750] [Bug #7925]
Actions #2

Updated by nagachika (Tomoyuki Chikanaga) about 11 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport200
  • Category deleted (core)
  • Status changed from Closed to Assigned
  • Assignee changed from shugo (Shugo Maeda) to nagachika (Tomoyuki Chikanaga)
  • Target version deleted (2.6)

I think this is definitely a bug-fix.

Actions #3

Updated by nagachika (Tomoyuki Chikanaga) about 11 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r39672.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39451: [Backport #7925]

* vm_insnhelper.c (vm_call_method): block level control frame does not
  have method entry, so obtain the method entry from method top-level
  control frame to be compared with refined method entry.
  [ruby-core:52750] [Bug #7925]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0