https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112013-02-24T15:33:50ZRuby Issue Tracking SystemBackport200 - Backport #7935: Array#sample with random generatorhttps://bugs.ruby-lang.org/issues/7935?journal_id=368952013-02-24T15:33:50Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r39466.<br>
Marc-Andre, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<p>random.c: increase limit for generic rand</p>
<ul>
<li>random.c (rb_random_ulong_limited): limit is inclusive, but generic<br>
rand method should return a number less than it, so increase for the<br>
difference. <a href="/issues/7935">[ruby-core:52779]</a> [Bug <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Backport: Array#sample with random generator (Closed)" href="https://bugs.ruby-lang.org/issues/7935">#7935</a>]</li>
</ul> Backport200 - Backport #7935: Array#sample with random generatorhttps://bugs.ruby-lang.org/issues/7935?journal_id=368962013-02-24T15:34:24Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Tracker</strong> changed from <i>Bug</i> to <i>Backport</i></li><li><strong>Project</strong> changed from <i>Ruby master</i> to <i>Backport200</i></li><li><strong>Category</strong> deleted (<del><i>core</i></del>)</li><li><strong>Status</strong> changed from <i>Closed</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>mame (Yusuke Endoh)</i></li><li><strong>Target version</strong> deleted (<del><i>2.6</i></del>)</li></ul> Backport200 - Backport #7935: Array#sample with random generatorhttps://bugs.ruby-lang.org/issues/7935?journal_id=369322013-02-24T23:05:27Znagachika (Tomoyuki Chikanaga)nagachika00@gmail.com
<ul><li><strong>Assignee</strong> changed from <i>mame (Yusuke Endoh)</i> to <i>nagachika (Tomoyuki Chikanaga)</i></li></ul> Backport200 - Backport #7935: Array#sample with random generatorhttps://bugs.ruby-lang.org/issues/7935?journal_id=374412013-03-09T23:57:51Znagachika (Tomoyuki Chikanaga)nagachika00@gmail.com
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li></ul><p>This issue was solved with changeset r39675.<br>
Marc-Andre, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<p>merge revision(s) 39466,39470: [Backport <a class="issue tracker-4 status-5 priority-4 priority-default closed" title="Backport: Array#sample with random generator (Closed)" href="https://bugs.ruby-lang.org/issues/7935">#7935</a>]</p>
<pre><code>* random.c (rb_random_ulong_limited): limit is inclusive, but generic
rand method should return a number less than it, so increase for the
difference. <a href="/issues/7935">[ruby-core:52779]</a> [Bug #7935]
* test/ruby/test_array.rb (test_sample_random): remove adjustment for
the bug fixed by r39466. <a href="/issues/7935">[ruby-core:52779]</a> [Bug #7935]
</code></pre>