Backport #7980: Segmentation fault when generating new key with OpenSSL

• Status: Closed
• Assignee: usa (Usaku NAKAMURA)

[dimytch (Dimitri Peka)]

=begin
The code below makes ruby to crash

If I change
cert.version, cert.serial = 2
to
cert.version = 2
cert.serial = 2
it passes to the undefined variable ((|root_ca|)) as expected

#!/usr/bin/ruby

encoding: utf-8

require 'openssl'

def new_key
key = OpenSSL::PKey::RSA.new 4096
cert = OpenSSL::X509::Certificate.new
cert.version, cert.serial = 2
cert.subject = OpenSSL::X509::Name.parse '/DC=Ivan Ivanov/DC=8055645654/DC=h@h/DC=/OU=client/O=Kontora/C=KZ'
cert.issuer = root_ca.subject
cert.public_key = key.public_key
cert.not_before = Time.now
cert.not_after = cert.not_before + 2 * 365 * 24 * 60 * 60
ef = OpenSSL::X509::ExtensionFactory.new
ef.subject_certificate = cert
ef.issuer_certificate = root_ca
cert.add_extension(ef.create_extension("keyUsage","digitalSignature", true))
cert.add_extension(ef.create_extension("subjectKeyIdentifier","hash",false))
cert.sign(@@root_key, OpenSSL::Digest::SHA256.new)
return cert
end

puts new_key

=end

[nobu (Nobuyoshi Nakada)]

• Description updated (diff)
• Category set to ext
• Status changed from Open to Assigned
• Assignee set to MartinBosslet (Martin Bosslet)

[nobu (Nobuyoshi Nakada)]

• Tracker changed from Bug to Backport
• Project changed from Ruby master to Backport193
• Category deleted (ext)

[nobu (Nobuyoshi Nakada)]

• Assignee changed from MartinBosslet (Martin Bosslet) to usa (Usaku NAKAMURA)

Seems r35159.

[usa (Usaku NAKAMURA)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r39980.
Dimitri, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

merge revision(s) 35159: [Backport #7980]

* ext/openssl/ossl_asn1.c: raise TypeError when trying to encode nil
  values for Primitive instances. 

* test/openssl/test_asn1.rb: Assert consistent behavior when
  encoding nil values: Primitives raise TypeError, Constructives
  raise NoMethodError.
  Fixes [ruby-core:43009][Bug #6102]