Project

General

Profile

Backport #7992

Backport r39544 - Fixes FileUtils bug #7958

Added by drbrain (Eric Hodel) almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:53057]

Description

This reverts r34669 which altered FileUtils metaprogramming in a way that broke FileUtils::Verbose, ::NoWrite and ::DryRun.

Patch: http://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/39544

Issue: http://bugs.ruby-lang.org/issues/7958


Related issues

Related to Ruby trunk - Bug #7958: include FileUtils::Verbose gives NoMethodError when installing files with a different modeClosed02/26/2013Actions

Associated revisions

Revision a5d40b28
Added by nagachika (Tomoyuki Chikanaga) almost 6 years ago

merge revision(s) 39544,39546: [Backport #7992]

* lib/fileutils.rb:  Revert r34669 which altered the way
  metaprogramming in FileUtils occurred.  [ruby-trunk - Bug #7958]

* test/fileutils/visibility_tests.rb:  Refactored tests of FileUtils
  options modules to expose bug found in #7958

* test/fileutils/test_dryrun.rb:  ditto.

* test/fileutils/test_nowrite.rb:  ditto.

* test/fileutils/test_verbose.rb:  ditto.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@40251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 40251
Added by nagachika (Tomoyuki Chikanaga) almost 6 years ago

merge revision(s) 39544,39546: [Backport #7992]

* lib/fileutils.rb:  Revert r34669 which altered the way
  metaprogramming in FileUtils occurred.  [ruby-trunk - Bug #7958]

* test/fileutils/visibility_tests.rb:  Refactored tests of FileUtils
  options modules to expose bug found in #7958

* test/fileutils/test_dryrun.rb:  ditto.

* test/fileutils/test_nowrite.rb:  ditto.

* test/fileutils/test_verbose.rb:  ditto.

History

Updated by drbrain (Eric Hodel) almost 6 years ago

  • Status changed from Open to Assigned

Updated by trans (Thomas Sawyer) almost 6 years ago

Response to my latest post on #7958 ?

Updated by mpapis (Michal Papis) almost 6 years ago

:+1: it will help to debug problems when installing Rubygems in RVM (every Ruby installation).

Updated by trans (Thomas Sawyer) almost 6 years ago

Can I ask exactly what are you +1'ing and why?

#6

Updated by nagachika (Tomoyuki Chikanaga) almost 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40251.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39544,39546: [Backport #7992]

* lib/fileutils.rb:  Revert r34669 which altered the way
  metaprogramming in FileUtils occurred.  [ruby-trunk - Bug #7958]

* test/fileutils/visibility_tests.rb:  Refactored tests of FileUtils
  options modules to expose bug found in #7958

* test/fileutils/test_dryrun.rb:  ditto.

* test/fileutils/test_nowrite.rb:  ditto.

* test/fileutils/test_verbose.rb:  ditto.

Also available in: Atom PDF