Backport #7992

Backport r39544 - Fixes FileUtils bug #7958

Added by Eric Hodel about 1 year ago. Updated about 1 year ago.

[ruby-core:53057]
Status:Closed
Priority:Normal
Assignee:Tomoyuki Chikanaga

Description

This reverts r34669 which altered FileUtils metaprogramming in a way that broke FileUtils::Verbose, ::NoWrite and ::DryRun.

Patch: http://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/39544

Issue: http://bugs.ruby-lang.org/issues/7958


Related issues

Related to ruby-trunk - Bug #7958: include FileUtils::Verbose gives NoMethodError when insta... Closed 02/26/2013

Associated revisions

Revision 40251
Added by Tomoyuki Chikanaga about 1 year ago

merge revision(s) 39544,39546: [Backport #7992]

* lib/fileutils.rb:  Revert r34669 which altered the way
  metaprogramming in FileUtils occurred.  [ruby-trunk - Bug #7958]

* test/fileutils/visibility_tests.rb:  Refactored tests of FileUtils
  options modules to expose bug found in #7958

* test/fileutils/test_dryrun.rb:  ditto.

* test/fileutils/test_nowrite.rb:  ditto.

* test/fileutils/test_verbose.rb:  ditto.

History

#1 Updated by Eric Hodel about 1 year ago

  • Status changed from Open to Assigned

#2 Updated by Thomas Sawyer about 1 year ago

Response to my latest post on #7958 ?

#3 Updated by Michal Papis about 1 year ago

:+1: it will help to debug problems when installing Rubygems in RVM (every Ruby installation).

#4 Updated by Artur Roszczyk about 1 year ago

+1

#5 Updated by Thomas Sawyer about 1 year ago

Can I ask exactly what are you +1'ing and why?

#6 Updated by Tomoyuki Chikanaga about 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40251.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39544,39546: [Backport #7992]

* lib/fileutils.rb:  Revert r34669 which altered the way
  metaprogramming in FileUtils occurred.  [ruby-trunk - Bug #7958]

* test/fileutils/visibility_tests.rb:  Refactored tests of FileUtils
  options modules to expose bug found in #7958

* test/fileutils/test_dryrun.rb:  ditto.

* test/fileutils/test_nowrite.rb:  ditto.

* test/fileutils/test_verbose.rb:  ditto.

Also available in: Atom PDF