Project

General

Profile

Backport #8008

super's implicit args behavior with keyword args

Added by nov (nov matake) over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:53114]

Description

I thought this sample says "Year!" 3 times, but actually, keyword args are't passed to super.
https://gist.github.com/nov/5075185

Is this intended behavior?
If so, please ignore this issue.

Associated revisions

Revision 221f2a1d
Added by nobu (Nobuyoshi Nakada) over 6 years ago

compile.c: zsuper keyword args

  • compile.c (iseq_compile_each): pass keyword arguments to zsuper, with current values. [ruby-core:53114] [Bug #8008]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@39627 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 39627
Added by nobu (Nobuyoshi Nakada) over 6 years ago

compile.c: zsuper keyword args

  • compile.c (iseq_compile_each): pass keyword arguments to zsuper, with current values. [ruby-core:53114] [Bug #8008]

Revision 39627
Added by nobu (Nobuyoshi Nakada) over 6 years ago

compile.c: zsuper keyword args

  • compile.c (iseq_compile_each): pass keyword arguments to zsuper, with current values. [ruby-core:53114] [Bug #8008]

Revision 39627
Added by nobu (Nobuyoshi Nakada) over 6 years ago

compile.c: zsuper keyword args

  • compile.c (iseq_compile_each): pass keyword arguments to zsuper, with current values. [ruby-core:53114] [Bug #8008]

Revision 39627
Added by nobu (Nobuyoshi Nakada) over 6 years ago

compile.c: zsuper keyword args

  • compile.c (iseq_compile_each): pass keyword arguments to zsuper, with current values. [ruby-core:53114] [Bug #8008]

Revision 39627
Added by nobu (Nobuyoshi Nakada) over 6 years ago

compile.c: zsuper keyword args

  • compile.c (iseq_compile_each): pass keyword arguments to zsuper, with current values. [ruby-core:53114] [Bug #8008]

Revision 39627
Added by nobu (Nobuyoshi Nakada) over 6 years ago

compile.c: zsuper keyword args

  • compile.c (iseq_compile_each): pass keyword arguments to zsuper, with current values. [ruby-core:53114] [Bug #8008]

Revision 03ec1e8e
Added by nagachika (Tomoyuki Chikanaga) about 6 years ago

merge revision(s) 39627: [Backport #8008]

    * compile.c (iseq_compile_each): pass keyword arguments to zsuper,
      with current values.  [ruby-core:53114] [Bug #8008]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@39914 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 39914
Added by nagachika (Tomoyuki Chikanaga) about 6 years ago

merge revision(s) 39627: [Backport #8008]

* compile.c (iseq_compile_each): pass keyword arguments to zsuper,
  with current values.  [ruby-core:53114] [Bug #8008]

Revision 0d7d3a80
Added by nagachika (Tomoyuki Chikanaga) about 6 years ago

merge revision(s) 39625,39626: [Backport #8008]

    compile.c: calc in int

    * compile.c (iseq_compile_each): calculate argc as int, not as Fixnum.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@39917 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 39917
Added by nagachika (Tomoyuki Chikanaga) about 6 years ago

merge revision(s) 39625,39626: [Backport #8008]

compile.c: calc in int

* compile.c (iseq_compile_each): calculate argc as int, not as Fixnum.

History

Updated by nobu (Nobuyoshi Nakada) over 6 years ago

  • Category set to core
  • Assignee set to nobu (Nobuyoshi Nakada)
  • Target version set to 2.1.0

Definitely a bug.

#2

Updated by nobu (Nobuyoshi Nakada) over 6 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r39627.
nov, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


compile.c: zsuper keyword args

  • compile.c (iseq_compile_each): pass keyword arguments to zsuper, with current values. [ruby-core:53114] [Bug #8008]
#3

Updated by nobu (Nobuyoshi Nakada) over 6 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby trunk to Backport200
  • Category deleted (core)
  • Status changed from Closed to Assigned
  • Assignee changed from nobu (Nobuyoshi Nakada) to nagachika (Tomoyuki Chikanaga)
  • Target version deleted (2.1.0)
#4

Updated by nagachika (Tomoyuki Chikanaga) about 6 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r39914.
nov, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39627: [Backport #8008]

* compile.c (iseq_compile_each): pass keyword arguments to zsuper,
  with current values.  [ruby-core:53114] [Bug #8008]

Updated by nagachika (Tomoyuki Chikanaga) about 6 years ago

  • Status changed from Closed to Assigned

I'm so sorry r39914 introduce compile error on ruby_2_0_0.
r39627 depend on r39626. I'll merge r39626.

Updated by nagachika (Tomoyuki Chikanaga) about 6 years ago

Hmm... r39626 cannot be merged cleanly.
I'll temporary revert r39914.

#7

Updated by nagachika (Tomoyuki Chikanaga) about 6 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r39917.
nov, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 39625,39626: [Backport #8008]

compile.c: calc in int

* compile.c (iseq_compile_each): calculate argc as int, not as Fixnum.

Also available in: Atom PDF