Backport #8135

Backport escape all closing parens - r39858 (Regexp macro %r{} is loosing backslash on "\}")

Added by Vit Ondruch about 1 year ago. Updated about 1 year ago.

[ruby-core:53599]
Status:Closed
Priority:High
Assignee:Tomoyuki Chikanaga

Description

Please backport r39858, i.e. #8133

Thank you.


Related issues

Duplicates ruby-trunk - Bug #8133: Regexp macro %r{} is loosing backslash on "\}" Closed 03/21/2013

Associated revisions

Revision 40169
Added by Tomoyuki Chikanaga about 1 year ago

merge revision(s) 39858: [Backport #8135]

* parse.y (simple_re_meta): escape all closing characters, not only
  round parenthesis.   [Bug #8133]

History

#1 Updated by Motohiro KOSAKI about 1 year ago

  1. You need to write a justification per every backport request.
  2. #8133 is still under discussion. You need to make an effort to get solid conclusion at first.

#2 Updated by Motohiro KOSAKI about 1 year ago

  • Subject changed from Backport escape all closing parens - r39858 to Backport escape all closing parens - r39858 (Regexp macro %r{} is loosing backslash on "\}")

#3 Updated by Anonymous about 1 year ago

Dne 21.3.2013 21:08, kosaki (Motohiro KOSAKI) napsal(a):

Issue #8135 has been updated by kosaki (Motohiro KOSAKI).

  1. You need to write a justification per every backport request.

It is regression against Ruby 1.9.3 from my POV. It bitten me running
https://github.com/josh/regin/blob/master/spec/parser_spec.rb#L23 which
used to work in 1.9.3.

  1. #8133 is still under discussion. You need to make an effort to get solid conclusion at first.

Sorry, but #8133 was closed and all clear when I opened this ticket. The
discussion began later. I couldn't know.

Vít

#4 Updated by Tomoyuki Chikanaga about 1 year ago

  • Status changed from Open to Assigned
  • Priority changed from Normal to High

Hello

Vit, sorry for late reaction.
I will merge it if there's no more claims in #8133 in a few days.

Thanks.

#5 Updated by Tomoyuki Chikanaga about 1 year ago

  • Assignee set to Tomoyuki Chikanaga

#6 Updated by Tomoyuki Chikanaga about 1 year ago

  • Status changed from Assigned to Closed

backported at r40169.

Also available in: Atom PDF