Project

General

Profile

Backport #8135

Backport escape all closing parens - r39858 (Regexp macro %r{} is loosing backslash on "\}")

Added by vo.x (Vit Ondruch) over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:53599]

Description

Please backport r39858, i.e. #8133

Thank you.


Related issues

Is duplicate of Ruby master - Bug #8133: Regexp macro %r{} is loosing backslash on "\}"Closed03/21/2013Actions

Associated revisions

Revision 6c0822f0
Added by nagachika (Tomoyuki Chikanaga) over 6 years ago

merge revision(s) 39858: [Backport #8135]

    * parse.y (simple_re_meta): escape all closing characters, not only
      round parenthesis.  [ruby-core:53578] [Bug #8133]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@40169 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 40169
Added by nagachika (Tomoyuki Chikanaga) over 6 years ago

merge revision(s) 39858: [Backport #8135]

* parse.y (simple_re_meta): escape all closing characters, not only
  round parenthesis.  [ruby-core:53578] [Bug #8133]

History

Updated by kosaki (Motohiro KOSAKI) over 6 years ago

  1. You need to write a justification per every backport request.
  2. #8133 is still under discussion. You need to make an effort to get solid conclusion at first.

Updated by kosaki (Motohiro KOSAKI) over 6 years ago

  • Subject changed from Backport escape all closing parens - r39858 to Backport escape all closing parens - r39858 (Regexp macro %r{} is loosing backslash on "\}")

Updated by Anonymous over 6 years ago

Dne 21.3.2013 21:08, kosaki (Motohiro KOSAKI) napsal(a):

Issue #8135 has been updated by kosaki (Motohiro KOSAKI).

  1. You need to write a justification per every backport request.

It is regression against Ruby 1.9.3 from my POV. It bitten me running
https://github.com/josh/regin/blob/master/spec/parser_spec.rb#L23 which
used to work in 1.9.3.

  1. #8133 is still under discussion. You need to make an effort to get solid conclusion at first.

Sorry, but #8133 was closed and all clear when I opened this ticket. The
discussion began later. I couldn't know.

Vít

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Status changed from Open to Assigned
  • Priority changed from Normal to 5

Hello

Vit, sorry for late reaction.
I will merge it if there's no more claims in #8133 in a few days.

Thanks.

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Assignee set to nagachika (Tomoyuki Chikanaga)

Updated by nagachika (Tomoyuki Chikanaga) over 6 years ago

  • Status changed from Assigned to Closed

backported at r40169.

Also available in: Atom PDF