Backport #8135: Backport escape all closing parens - r39858 (Regexp macro %r{} is loosing backslash on "\}")

• Status: Closed
• Assignee: nagachika (Tomoyuki Chikanaga)

[vo.x (Vit Ondruch)]

Please backport r39858, i.e. #8133

Thank you.

[kosaki (Motohiro KOSAKI)]

1. You need to write a justification per every backport request.
2. #8133 is still under discussion. You need to make an effort to get solid conclusion at first.

[kosaki (Motohiro KOSAKI)]

• Subject changed from Backport escape all closing parens - r39858 to Backport escape all closing parens - r39858 (Regexp macro %r{} is loosing backslash on "\}")

Dne 21.3.2013 21:08, kosaki (Motohiro KOSAKI) napsal(a):

Issue #8135 has been updated by kosaki (Motohiro KOSAKI).

1. You need to write a justification per every backport request.

It is regression against Ruby 1.9.3 from my POV. It bitten me running
https://github.com/josh/regin/blob/master/spec/parser_spec.rb#L23 which
used to work in 1.9.3.

2. #8133 is still under discussion. You need to make an effort to get solid conclusion at first.

Sorry, but #8133 was closed and all clear when I opened this ticket. The
discussion began later. I couldn't know.

Vít

[nagachika (Tomoyuki Chikanaga)]

• Status changed from Open to Assigned
• Priority changed from Normal to 5

Hello

Vit, sorry for late reaction.
I will merge it if there's no more claims in #8133 in a few days.

Thanks.

[nagachika (Tomoyuki Chikanaga)]

• Assignee set to nagachika (Tomoyuki Chikanaga)

[nagachika (Tomoyuki Chikanaga)]

• Status changed from Assigned to Closed

backported at r40169.