Project

General

Profile

Actions

Backport #8222

closed

Curses#crmode is not crmode

Added by nobu (Nobuyoshi Nakada) almost 11 years ago. Updated almost 11 years ago.


Description

Since r21900, crmode is not cbreak but nocbreak.
For instance, ext/curses/hello.rb waits until a newline.


Related issues 1 (0 open1 closed)

Related to Ruby master - Feature #916: Curses.crmodeとCurses.nocrmodeをモジュール関数に変更するClosedActions

Updated by nobu (Nobuyoshi Nakada) almost 11 years ago

  • Description updated (diff)
Actions #2

Updated by nobu (Nobuyoshi Nakada) almost 11 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40118.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


curses.c: fix function

  • ext/curses/curses.c (Init_curses): fix implementation function,
    crmode should be same as cbreak. [ruby-core:54013] [Bug #8222]
Actions #3

Updated by nobu (Nobuyoshi Nakada) almost 11 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport200
  • Category deleted (ext)
  • Status changed from Closed to Assigned
  • Assignee set to nagachika (Tomoyuki Chikanaga)
Actions #4

Updated by nagachika (Tomoyuki Chikanaga) almost 11 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40311.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40117,40118: [Backport #8222]

* test/test_curses.rb: tests for getch.
* ext/curses/curses.c (Init_curses): fix implementation function,
  crmode should be same as cbreak.  [ruby-core:54013] [Bug #8222]

Updated by nagachika (Tomoyuki Chikanaga) almost 11 years ago

  • Status changed from Closed to Assigned

I reverted r40311 at r40313.
It breaks curses tests in rubyci.org.

Updated by nagachika (Tomoyuki Chikanaga) almost 11 years ago

memo: maybe r40333 is needed.

Actions #7

Updated by nagachika (Tomoyuki Chikanaga) almost 11 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40388.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40117,40118,40333: [Backport #8222]

* test/test_curses.rb: tests for getch.
* ext/curses/curses.c (Init_curses): fix implementation function,
  crmode should be same as cbreak.  [ruby-core:54013] [Bug #8222]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0Like0Like0Like0Like0