Project

General

Profile

Backport #8222

Curses#crmode is not crmode

Added by nobu (Nobuyoshi Nakada) almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:54013]

Description

Since r21900, crmode is not cbreak but nocbreak.
For instance, ext/curses/hello.rb waits until a newline.


Related issues

Related to Ruby master - Feature #916: Curses.crmodeとCurses.nocrmodeをモジュール関数に変更するClosedActions

Updated by nobu (Nobuyoshi Nakada) almost 8 years ago

  • Description updated (diff)
#2

Updated by nobu (Nobuyoshi Nakada) almost 8 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40118.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


curses.c: fix function

  • ext/curses/curses.c (Init_curses): fix implementation function, crmode should be same as cbreak. [ruby-core:54013] [Bug #8222]
#3

Updated by nobu (Nobuyoshi Nakada) almost 8 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport200
  • Category deleted (ext)
  • Status changed from Closed to Assigned
  • Assignee set to nagachika (Tomoyuki Chikanaga)
#4

Updated by nagachika (Tomoyuki Chikanaga) almost 8 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40311.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40117,40118: [Backport #8222]

* test/test_curses.rb: tests for getch.
* ext/curses/curses.c (Init_curses): fix implementation function,
  crmode should be same as cbreak.  [ruby-core:54013] [Bug #8222]

Updated by nagachika (Tomoyuki Chikanaga) almost 8 years ago

  • Status changed from Closed to Assigned

I reverted r40311 at r40313.
It breaks curses tests in rubyci.org.

Updated by nagachika (Tomoyuki Chikanaga) over 7 years ago

memo: maybe r40333 is needed.

#7

Updated by nagachika (Tomoyuki Chikanaga) over 7 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40388.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40117,40118,40333: [Backport #8222]

* test/test_curses.rb: tests for getch.
* ext/curses/curses.c (Init_curses): fix implementation function,
  crmode should be same as cbreak.  [ruby-core:54013] [Bug #8222]

Also available in: Atom PDF