Backport #8222

Curses#crmode is not crmode

Added by Nobuyoshi Nakada almost 2 years ago. Updated almost 2 years ago.

[ruby-core:54013]
Status:Closed
Priority:Normal
Assignee:Tomoyuki Chikanaga

Description

Since r21900, crmode is not cbreak but nocbreak.
For instance, ext/curses/hello.rb waits until a newline.


Related issues

Related to Ruby trunk - Feature #916: Curses.crmodeとCurses.nocrmodeをモジュール関数に変更する Closed

Associated revisions

Revision 40118
Added by Nobuyoshi Nakada almost 2 years ago

curses.c: fix function

  • ext/curses/curses.c (Init_curses): fix implementation function, crmode should be same as cbreak. [Bug #8222]

Revision 40311
Added by Tomoyuki Chikanaga almost 2 years ago

merge revision(s) 40117,40118: [Backport #8222]

* test/test_curses.rb: tests for getch.
* ext/curses/curses.c (Init_curses): fix implementation function,
  crmode should be same as cbreak.   [Bug #8222]

Revision 40388
Added by Tomoyuki Chikanaga almost 2 years ago

merge revision(s) 40117,40118,40333: [Backport #8222]

* test/test_curses.rb: tests for getch.
* ext/curses/curses.c (Init_curses): fix implementation function,
  crmode should be same as cbreak.   [Bug #8222]

History

#1 Updated by Nobuyoshi Nakada almost 2 years ago

  • Description updated (diff)

#2 Updated by Nobuyoshi Nakada almost 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40118.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


curses.c: fix function

  • ext/curses/curses.c (Init_curses): fix implementation function, crmode should be same as cbreak. [Bug #8222]

#3 Updated by Nobuyoshi Nakada almost 2 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby trunk to Backport200
  • Category deleted (ext)
  • Status changed from Closed to Assigned
  • Assignee set to Tomoyuki Chikanaga

#4 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40311.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40117,40118: [Backport #8222]

* test/test_curses.rb: tests for getch.
* ext/curses/curses.c (Init_curses): fix implementation function,
  crmode should be same as cbreak.   [Bug #8222]

#5 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Status changed from Closed to Assigned

I reverted r40311 at r40313.
It breaks curses tests in rubyci.org.

#6 Updated by Tomoyuki Chikanaga almost 2 years ago

memo: maybe r40333 is needed.

#7 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40388.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40117,40118,40333: [Backport #8222]

* test/test_curses.rb: tests for getch.
* ext/curses/curses.c (Init_curses): fix implementation function,
  crmode should be same as cbreak.   [Bug #8222]

Also available in: Atom PDF