Backport #8228

atomic_ops unavailable on Solaris 9 or earlier

Added by Naohisa Goto almost 2 years ago. Updated almost 2 years ago.

[ruby-dev:47231]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

アトミックな演算(man atomic_ops 参照)はSolaris 9以前には存在しないが使おうとするため、Solaris8でSunのコンパイラでは1.9.3以降がコンパイルできない、との指摘があったとtwitterで知らせてもらいました。

kosakiさん作成のパッチ https://gist.github.com/kosaki/5260762 にて、Solaris10では #define HAVE_ATOMIC_H 1 となりSolaris用atomic関数が使われることは確認しました。

20130410-ruby193-solaris-atomic.patch Magnifier (974 Bytes) Naohisa Goto, 04/10/2013 06:15 PM

20130410-ruby200-solaris-atomic.patch Magnifier (961 Bytes) Naohisa Goto, 04/10/2013 06:15 PM

Associated revisions

Revision 40163
Added by Naohisa Goto almost 2 years ago

  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [Bug #8228]

Revision 40716
Added by Usaku NAKAMURA almost 2 years ago

merge revision(s) 40163: [Backport #8228]

* configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

* ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
  earlier if atomic.h is not available.  [Bug #8228]

History

#1 Updated by Naohisa Goto almost 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40163.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [Bug #8228]

#2 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby trunk to Backport200
  • Status changed from Closed to Assigned
  • Assignee changed from Naohisa Goto to Tomoyuki Chikanaga

ruby_2_0_0 へバックポートしたいと思います。
ruby_1_9_3 にも必要でしょうか? 多分ヘッダファイル名が変更されていて別途パッチを作らないといけない気がします(未確認)。

#3 Updated by Naohisa Goto almost 2 years ago

ruby_1_9_3 にもバックポート希望ですが、ruby_atomic.h は ruby_1_9_3 でもファイル名変更済みで問題ありません。
それより configure.in のほうが変化が激しく、素直にパッチが当たりませんでした。
ruby_1_9_3 用、 ruby_2_0_0 用のパッチをそれぞれ添付します。(ChangeLog以外)

#4 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40285.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40163: [Backport #8228]

* configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

* ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
  earlier if atomic.h is not available.  [Bug #8228]

#5 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Project changed from Backport200 to Backport193
  • Status changed from Closed to Assigned
  • Assignee changed from Tomoyuki Chikanaga to Usaku NAKAMURA

#6 Updated by Usaku NAKAMURA almost 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40716.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40163: [Backport #8228]

* configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

* ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
  earlier if atomic.h is not available.  [Bug #8228]

Also available in: Atom PDF