Project

General

Profile

Backport #8228

atomic_ops unavailable on Solaris 9 or earlier

Added by ngoto (Naohisa Goto) about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-dev:47231]

Description

アトミックな演算(man atomic_ops 参照)はSolaris 9以前には存在しないが使おうとするため、Solaris8でSunのコンパイラでは1.9.3以降がコンパイルできない、との指摘があったとtwitterで知らせてもらいました。

kosakiさん作成のパッチ https://gist.github.com/kosaki/5260762 にて、Solaris10では #define HAVE_ATOMIC_H 1 となりSolaris用atomic関数が使われることは確認しました。


Files

20130410-ruby193-solaris-atomic.patch (974 Bytes) 20130410-ruby193-solaris-atomic.patch ngoto (Naohisa Goto), 04/10/2013 06:15 PM
20130410-ruby200-solaris-atomic.patch (961 Bytes) 20130410-ruby200-solaris-atomic.patch ngoto (Naohisa Goto), 04/10/2013 06:15 PM

Associated revisions

Revision f70a7cd2
Added by ngoto (Naohisa Goto) about 6 years ago

  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@40163 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 40163
Added by ngoto (Naohisa Goto) about 6 years ago

  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

Revision 40163
Added by ngoto (Naohisa Goto) about 6 years ago

  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

Revision 40163
Added by ngoto (Naohisa Goto) about 6 years ago

  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

Revision 40163
Added by ngoto (Naohisa Goto) about 6 years ago

  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

Revision 40163
Added by ngoto (Naohisa Goto) about 6 years ago

  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

Revision 40163
Added by ngoto (Naohisa Goto) about 6 years ago

  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

Revision 7bc0cea7
Added by nagachika (Tomoyuki Chikanaga) about 6 years ago

merge revision(s) 40163: [Backport #8228]

    * configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

    * ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
      earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@40285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision fd9c5580
Added by usa (Usaku NAKAMURA) about 6 years ago

merge revision(s) 40163: [Backport #8228]

    * configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

    * ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
      earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@40716 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 40716
Added by usa (Usaku NAKAMURA) about 6 years ago

merge revision(s) 40163: [Backport #8228]

* configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

* ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
  earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

History

#1

Updated by ngoto (Naohisa Goto) about 6 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40163.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.
  • ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]
#2

Updated by nagachika (Tomoyuki Chikanaga) about 6 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby trunk to Backport200
  • Status changed from Closed to Assigned
  • Assignee changed from ngoto (Naohisa Goto) to nagachika (Tomoyuki Chikanaga)

ruby_2_0_0 へバックポートしたいと思います。
ruby_1_9_3 にも必要でしょうか? 多分ヘッダファイル名が変更されていて別途パッチを作らないといけない気がします(未確認)。

Updated by ngoto (Naohisa Goto) about 6 years ago

ruby_1_9_3 にもバックポート希望ですが、ruby_atomic.h は ruby_1_9_3 でもファイル名変更済みで問題ありません。
それより configure.in のほうが変化が激しく、素直にパッチが当たりませんでした。
ruby_1_9_3 用、 ruby_2_0_0 用のパッチをそれぞれ添付します。(ChangeLog以外)

#4

Updated by nagachika (Tomoyuki Chikanaga) about 6 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40285.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40163: [Backport #8228]

* configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

* ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
  earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]
#5

Updated by nagachika (Tomoyuki Chikanaga) about 6 years ago

  • Project changed from Backport200 to Backport193
  • Status changed from Closed to Assigned
  • Assignee changed from nagachika (Tomoyuki Chikanaga) to usa (Usaku NAKAMURA)
#6

Updated by usa (Usaku NAKAMURA) about 6 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r40716.
Naohisa, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40163: [Backport #8228]

* configure.in (AC_CHECK_HEADERS): atomic.h for Solaris atomic_ops.

* ruby_atomic.h: Skip using Solaris10 atomic_ops on Solaris 9 or
  earlier if atomic.h is not available. [ruby-dev:47229] [Bug #8228]

Also available in: Atom PDF