Backport #8281: Net::IMAP can't parse response to the IMAP SETACL command correctly

• Status: Closed
• Assignee: usa (Usaku NAKAMURA)

[adantel (Alex Filatau)]

Found in ruby-2.0.0-p0

I'm working right now on upgrade of our test system from ruby 1.9.2 to ruby 2.0.0. Unfortunately, one of the test scripts that works flawlessly with ruby 1.9.2 is failing when trying to parse response of GETACL command. See the debug of the session below:

C: RUBY0002 CREATE INBOX/share
S: RUBY0002 OK CREATE completed
C: RUBY0003 SETACL INBOX/share [e-mail] lrswickxteda
S: RUBY0003 OK SETACL completed
C: RUBY0004 GETACL INBOX/share
S: * ACL "INBOX/share" "[e-mail]" lrswickxteda "[e-mail]" lrswickxteda
@str: "* ACL "INBOX/share" "[e-mail]" lrswickxteda "[e-mail]" lrswickxteda\r\n"
@pos: 19
@lex_state: EXPR_BEG
@token.symbol: QUOTED
@token.value: "INBOX/share"
#<Net::IMAP::ResponseParseError: unexpected token QUOTED (expected CRLF)>
/usr/local/rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/net/imap.rb:3363:in parse_error' /usr/local/rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/net/imap.rb:3215:in match'
/usr/local/rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/net/imap.rb:2136:in response' /usr/local/rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/net/imap.rb:2058:in parse'
/usr/local/rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/net/imap.rb:1181:in get_response' /usr/local/rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/net/imap.rb:1089:in receive_responses'
/usr/local/rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/net/imap.rb:1075:in `block in initialize'

Please note, the same piece is working fine with ruby 1.9.2

[adantel (Alex Filatau)]

It looks like the problem is in method getacl_response. Someone removed "mailbox = astring" line from there dot fixing the consequences. Returning this line back makes code happy and the response_untagged gets correct Net::IMAP::UntaggedResponse with non empty data attribute for ACL commands.

That's the in fact done in the following commit https://github.com/ruby/ruby/commit/f3e35474078895e1d178e15cfbfc6743f9ffc62d#lib/net/imap.rb
mailbox variable is not used indeed, but the astring is doing one lookahead call, that shifts focus to the next token, and that's expected by future code.

[shugo (Shugo Maeda)]

• Status changed from Open to Assigned
• Assignee set to shugo (Shugo Maeda)

[shugo (Shugo Maeda)]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r40419.
Alex, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• lib/net/imap.rb (getacl_response): parse the mailbox of an ACL
  response correctly. [ruby-core:54365] [Bug #8281]

[nagachika (Tomoyuki Chikanaga)]

• Tracker changed from Bug to Backport
• Project changed from Ruby to 15
• Status changed from Closed to Assigned
• Assignee changed from shugo (Shugo Maeda) to nagachika (Tomoyuki Chikanaga)

[nagachika (Tomoyuki Chikanaga)]

• Status changed from Assigned to Closed

This issue was solved with changeset r40426.
Alex, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

merge revision(s) 40419: [Backport #8281]

* lib/net/imap.rb (getacl_response): parse the mailbox of an ACL
  response correctly.  [ruby-core:54365] [Bug #8281]

[nagachika (Tomoyuki Chikanaga)]

• Project changed from 15 to 13
• Status changed from Closed to Assigned

[nagachika (Tomoyuki Chikanaga)]

• Assignee changed from nagachika (Tomoyuki Chikanaga) to usa (Usaku NAKAMURA)

[usa (Usaku NAKAMURA)]

• Status changed from Assigned to Closed

This issue was solved with changeset r40718.
Alex, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

merge revision(s) 40419: [Backport #8281]

* lib/net/imap.rb (getacl_response): parse the mailbox of an ACL
  response correctly.  [ruby-core:54365] [Bug #8281]