Backport #8328
closedr40457 - Hash#shift performance improvement
Description
r40457 contains a patch which significantly improves the performance of Hash#shift.
As it does not change behaviour, it should be backported.
Thanks.
Files
Updated by usa (Usaku NAKAMURA) almost 11 years ago
- Status changed from Open to Assigned
- Assignee set to usa (Usaku NAKAMURA)
Sorry for late reply.
trunk is too different from 1.9.3, so I cannot patch r40457 simply.
Please wait more.
Updated by funny_falcon (Yura Sokolov) almost 11 years ago
- File backport_fix_shift.diff backport_fix_shift.diff added
Backported version of "fix Hash#shift" attached.
Updated by usa (Usaku NAKAMURA) almost 11 years ago
- Status changed from Assigned to Closed
- % Done changed from 0 to 100
This issue was solved with changeset r41652.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.
[Backport #8328] [ruby-core:55250] Patch by funny-falcon
-
benchmark/bm_hash_shift.rb: add benchmark for Hash#shift
-
hash.c (rb_hash_shift): use st_shift if hash is not being iterated to
delete element without iterating the whole hash. -
hash.c (shift_i): remove function
-
include/ruby/st.h (st_shift): add st_shift function
-
st.c (st_shift): ditto