Backport #8345

Method#to_proc assumes lambda returns a Proc

Added by Charlie Somerville almost 2 years ago. Updated almost 2 years ago.

[ruby-core:54687]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

=begin
Method#to_proc calls #lambda and assumes the return value is a Proc by passing it to GetProcPtr.

If #lambda is overridden this can cause segfaults:

def lambda
end

method(:puts).to_proc # segfault

=end

Associated revisions

Revision 40528
Added by Nobuyoshi Nakada almost 2 years ago

proc.c: frozen core methods

  • proc.c (mproc, mlambda): use frozen core methods instead of plain global methods, so that methods cannot be overridden. [Bug #8345]
  • vm.c (Init_VM): define proc and lambda on the frozen core object.

Revision 41649
Added by Usaku NAKAMURA almost 2 years ago

merge revision(s) 40525,40526,40528,40530: [Backport #8345]

proc.c: remove unnecessary static function

* proc.c (proc_lambda): remove and use rb_block_lambda directly

instead.
* include/ruby/intern.h (rb_block_lambda): add declaration instead of
deprecated rb_f_lambda.

* proc.c (mproc, mlambda): use frozen core methods instead of plain
  global methods, so that methods cannot be overridden.
   [Bug #8345]

* vm.c (Init_VM): define proc and lambda on the frozen core object.

* defs/id.def (predefined): add "idProc".

* proc.c (mnew, mproc, mlambda): use predefined IDs.

* vm.c (Init_VM): ditto.

History

#1 Updated by Charlie Somerville almost 2 years ago

=begin
The same happens with Proc#curry too:

def proc
end

->{}.curry

=end

#2 Updated by Nobuyoshi Nakada almost 2 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40528.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


proc.c: frozen core methods

  • proc.c (mproc, mlambda): use frozen core methods instead of plain global methods, so that methods cannot be overridden. [Bug #8345]
  • vm.c (Init_VM): define proc and lambda on the frozen core object.

#3 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 1.9.3: REQUIRED, 2.0.0: REQUIRED

This issue seems like happen in 1.9.3p433 and 2.0.0p222.

#4 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Project changed from Ruby trunk to Backport200
  • Assignee changed from Charlie Somerville to Tomoyuki Chikanaga
  • Status changed from Closed to Assigned
  • Tracker changed from Bug to Backport

#5 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r41394.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40525,40526,40528,40530: [Backport #8345]

proc.c: remove unnecessary static function

* proc.c (proc_lambda): remove and use rb_block_lambda directly

instead.
* include/ruby/intern.h (rb_block_lambda): add declaration instead of
deprecated rb_f_lambda.

* proc.c (mproc, mlambda): use frozen core methods instead of plain
  global methods, so that methods cannot be overridden.
   [Bug #8345]

* vm.c (Init_VM): define proc and lambda on the frozen core object.

* defs/id.def (predefined): add "idProc".

* proc.c (mnew, mproc, mlambda): use predefined IDs.

* vm.c (Init_VM): ditto.

#6 Updated by Tomoyuki Chikanaga almost 2 years ago

  • Assignee changed from Tomoyuki Chikanaga to Usaku NAKAMURA
  • Project changed from Backport200 to Backport193
  • Status changed from Closed to Assigned

#7 Updated by Usaku NAKAMURA almost 2 years ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r41649.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 40525,40526,40528,40530: [Backport #8345]

proc.c: remove unnecessary static function

* proc.c (proc_lambda): remove and use rb_block_lambda directly

instead.
* include/ruby/intern.h (rb_block_lambda): add declaration instead of
deprecated rb_f_lambda.

* proc.c (mproc, mlambda): use frozen core methods instead of plain
  global methods, so that methods cannot be overridden.
   [Bug #8345]

* vm.c (Init_VM): define proc and lambda on the frozen core object.

* defs/id.def (predefined): add "idProc".

* proc.c (mnew, mproc, mlambda): use predefined IDs.

* vm.c (Init_VM): ditto.

Also available in: Atom PDF