Backport #8406

Bad backport of r39578 in r40098 breaks build on OpenBSD

Added by Jeremy Evans 11 months ago. Updated 11 months ago.

[ruby-core:54990]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

=begin
SVN r39578 reorders compiler arguments in Makefile.in. However, when it was backported to 1.9.3 as r40098, it added an additional line that breaks the build on OpenBSD. The line added is "$(Q) $(POSTLINK)", but POSTLINK doesn't appear to exist in 1.9.3.

r39578: http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/Makefile.in?r1=39578&r2=39577&pathrev=39578
r40098: http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_9_3/Makefile.in?r1=40098&r2=40097&pathrev=40098

I'm not sure why this breaks on OpenBSD, but my guess is differences between BSD make and GNU make. In any case, the "$(Q) $(POSTLINK)" line should be removed in 1.9.3.

I know you are not supposed to open new issues in the Backport93 project, but considering this is due to a bad backport, I think an exception is warranted.
=end

Associated revisions

Revision 40983
Added by Usaku NAKAMURA 11 months ago

merge revision(s) 35589: [Backport #8406]

* configure.in (POSTLINK): default to : command to get rid of flag
  only command, since BSD make does not work with it.

History

#1 Updated by Tomoyuki Chikanaga 11 months ago

  • Status changed from Open to Assigned
  • Assignee set to Usaku NAKAMURA

Hello, jeremy
Thank you for your reporting this issue. I think it is OK to open a ticket in Backport93 in such a case.

usa san.
I think r35589 is necessary to be backported to ruby19_3, maybe.

#2 Updated by Jeremy Evans 11 months ago

This appears to be fixed by r40754.

#3 Updated by Usaku NAKAMURA 11 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40983.
Jeremy, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 35589: [Backport #8406]

* configure.in (POSTLINK): default to : command to get rid of flag
  only command, since BSD make does not work with it.

Also available in: Atom PDF