Project

General

Profile

Actions

Backport #8406

closed

Bad backport of r39578 in r40098 breaks build on OpenBSD

Added by jeremyevans0 (Jeremy Evans) almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
[ruby-core:54990]

Description

=begin
SVN r39578 reorders compiler arguments in Makefile.in. However, when it was backported to 1.9.3 as r40098, it added an additional line that breaks the build on OpenBSD. The line added is "$(Q) $(POSTLINK)", but POSTLINK doesn't appear to exist in 1.9.3.

r39578: http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/trunk/Makefile.in?r1=39578&r2=39577&pathrev=39578
r40098: http://svn.ruby-lang.org/cgi-bin/viewvc.cgi/branches/ruby_1_9_3/Makefile.in?r1=40098&r2=40097&pathrev=40098

I'm not sure why this breaks on OpenBSD, but my guess is differences between BSD make and GNU make. In any case, the "$(Q) $(POSTLINK)" line should be removed in 1.9.3.

I know you are not supposed to open new issues in the Backport93 project, but considering this is due to a bad backport, I think an exception is warranted.
=end

Updated by nagachika (Tomoyuki Chikanaga) almost 11 years ago

  • Status changed from Open to Assigned
  • Assignee set to usa (Usaku NAKAMURA)

Hello, jeremy
Thank you for your reporting this issue. I think it is OK to open a ticket in Backport93 in such a case.

usa san.
I think r35589 is necessary to be backported to ruby_1_9_3, maybe.

Updated by jeremyevans0 (Jeremy Evans) almost 11 years ago

This appears to be fixed by r40754.

Actions #3

Updated by usa (Usaku NAKAMURA) almost 11 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r40983.
Jeremy, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 35589: [Backport #8406]

* configure.in (POSTLINK): default to : command to get rid of flag
  only command, since BSD make does not work with it.
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0