Backport #8463

Proc auto-splat bug with named arguments

Added by Marc-Andre Lafortune 11 months ago. Updated 11 months ago.

[ruby-core:55203]
Status:Closed
Priority:High
Assignee:Tomoyuki Chikanaga

Description

=begin
I'd expect a proc to either do an implicit splat or not, but right now it looks for options before doing the implicit splat. Should it not do it after doing the implicit splat?

I thought that when a proc had an argument list with more than one element, it was the same to call it with a single array argument than with the same array splatted:

Proc{|a, ...| ... }.call([...]) == Proc{|a, ...}| ... }.call(*[...]) # => Because of implicit splat

But we have currently:

Proc.new{|a, b, *c| p a, b, c}.call(1,2, bar: 3)
# => 1, [2], {:bar=>3} : OK

Proc.new{|a, b, *c| p a, b, c}.call([1,2, bar: 3])
# => 1, [2, {:bar=>3}], {}: Expected same as above

Proc.new{|(a, b), *c| p a, b, c}.call([1,2], bar: 3)
# => 1, [2], {:bar=>3} : OK

Proc.new{|(a, b), *c| p a, b, c}.call([[1,2], bar: 3])
# => [1, 2], [{:bar=>3}], {}: Expected same as above

As an additional note, this affects some methods of Enumerable when yielding multiple arguments.

For example:

def each; yield 1, 2, bar: 3; end
include Enumerable

each{|a, *b, **c| p a, b, c} # => 1, [2], {:bar => 3}: ok
detect{|a, *b, **c| p a, b, c} # => 1, [2, {:bar => 3}], {}: should be the same, no?

=end


Related issues

Related to ruby-trunk - Bug #8457: Function arguments: Is this intended? Closed 05/29/2013

Associated revisions

Revision 41262
Added by Tomoyuki Chikanaga 11 months ago

merge revision(s) 41019,41020,41021,41041,41045,41057: [Backport #8463]

vm_insnhelper.c: add comments

* vm_insnhelper.c (vm_yield_setup_block_args): break a long line and

add comments. remove useless code.
* vminsnhelper.c (vmyieldsetupblock_args): split single parameter
if any keyword arguments exist, and then extract keyword arguments.
[Bug #8463]

* compile.c (iseq_set_arguments): not a simple single argument if any
  keyword arguments exist.   [Bug #8463]

* vm_insnhelper.c (vm_yield_setup_block_args): partially revert r41019.
  The code is not useless.

History

#1 Updated by Nobuyoshi Nakada 11 months ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41020.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


vm_insnhelper.c: extract keyword arguments after splat

  • vminsnhelper.c (vmyieldsetupblock_args): split single parameter if any keyword arguments exist, and then extract keyword arguments. [Bug #8463]

#2 Updated by Nobuyoshi Nakada 11 months ago

  • Description updated (diff)
  • Status changed from Closed to Open
  • % Done changed from 100 to 50

#3 Updated by Nobuyoshi Nakada 11 months ago

  • % Done changed from 50 to 100
  • Status changed from Open to Closed

This issue was solved with changeset r41021.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


compile.c: not simple if keyword args

  • compile.c (iseqsetarguments): not a simple single argument if any keyword arguments exist. [Bug #8463]

#4 Updated by Nobuyoshi Nakada 11 months ago

  • Backport changed from 1.9.3: UNKNOWN, 2.0.0: UNKNOWN to 2.0.0: REQUIRED

#5 Updated by Tomoyuki Chikanaga 11 months ago

  • Tracker changed from Bug to Backport
  • Project changed from ruby-trunk to Backport200
  • Category deleted (core)
  • Status changed from Closed to Assigned
  • Assignee changed from Nobuyoshi Nakada to Tomoyuki Chikanaga

#6 Updated by Tomoyuki Chikanaga 11 months ago

  • Status changed from Assigned to Closed

This issue was solved with changeset r41262.
Marc-Andre, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41019,41020,41021,41041,41045,41057: [Backport #8463]

vm_insnhelper.c: add comments

* vm_insnhelper.c (vm_yield_setup_block_args): break a long line and

add comments. remove useless code.
* vminsnhelper.c (vmyieldsetupblock_args): split single parameter
if any keyword arguments exist, and then extract keyword arguments.
[Bug #8463]

* compile.c (iseq_set_arguments): not a simple single argument if any
  keyword arguments exist.   [Bug #8463]

* vm_insnhelper.c (vm_yield_setup_block_args): partially revert r41019.
  The code is not useless.

Also available in: Atom PDF