Project

General

Profile

Backport #8503

Backport r41175

Added by charliesome (Charlie Somerville) about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:55374]

Description

r41175 fixes Module#include failing to increment ruby_vm_global_state_version when a module without any methods was included into a class.

This can cause constant lookups to be incorrectly cached.

Associated revisions

Revision a43b8412
Added by usa (Usaku NAKAMURA) about 6 years ago

merge revision(s) 41175: [Backport #8503]

    * class.c (include_modules_at): invalidate method cache if included
      module contains constants

    * test/ruby/test_module.rb: add test

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@41645 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 41645
Added by usa (Usaku NAKAMURA) about 6 years ago

merge revision(s) 41175: [Backport #8503]

* class.c (include_modules_at): invalidate method cache if included
  module contains constants

* test/ruby/test_module.rb: add test

History

#1

Updated by usa (Usaku NAKAMURA) about 6 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41645.
Charlie, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41175: [Backport #8503]

* class.c (include_modules_at): invalidate method cache if included
  module contains constants

* test/ruby/test_module.rb: add test

Also available in: Atom PDF