Project

General

Profile

Actions

Backport #8554

closed

Backport r41325 (fix unexpected GC)

Added by authorNari (Narihiro Nakamura) almost 11 years ago. Updated almost 11 years ago.


Description

taruiさんが入れてくださった r41325 のバックポートをお願いします。

LazySweep中にmalloc_increaseがクリアされておらず、LazySweep中にmallocが発生すると期待していないタイミングでGCが動いてしまっていました(GCの二度打ち)。
パッチは本チケットに添付しています。

また、このバックポートでmake rdocは以下のように速度改善するようです。
https://gist.github.com/authorNari/5829089


Files

ruby-200-backport-r41325.patch (2.4 KB) ruby-200-backport-r41325.patch authorNari (Narihiro Nakamura), 06/21/2013 02:57 PM

Updated by nagachika (Tomoyuki Chikanaga) almost 11 years ago

  • Subject changed from Backport r41325 to Backport r41325 (fix unexpected GC)
  • Status changed from Open to Assigned
  • Priority changed from Normal to 5

ありがとうございます。マージします。

Actions #2

Updated by nagachika (Tomoyuki Chikanaga) almost 11 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r41577.
Narihiro, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 41325: [Backport #8554]

  • gc.c: Fixup around GC by MALLOC.
    Add allocate size to malloc_increase before GC
    for updating limit in after_gc_sweep.
    Reset malloc_increase into garbage_collect()
    for preventing GC again soon.
Actions

Also available in: Atom PDF

Like0
Like0Like0