Project

General

Profile

Backport #8752

please backport r42439

Added by usa (Usaku NAKAMURA) about 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-dev:<unknown>]

Description

WindowsのCIで異様に時間がかかるtestがあるのですが、
実は無駄な時間消費なのでそれを改善するための変更です。

Associated revisions

Revision 2f3915d4
Added by nagachika (Tomoyuki Chikanaga) about 6 years ago

merge revision(s) 42439,42453: [Backport #8752]

    * test/coverage/test_coverage.rb (TestCoverage#test_big_code): use `1'
      instead of `p' to get rid of a side effect.
      Kernel#p without any argument seems to do nothing, but flushes stdout.
      and, if stdout is redirected to file, fsync() will be called on
      Windows.  so, when running test-all on Windows with redirection, such
      as CI environment, this test took a lot of time.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@42492 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 42492
Added by nagachika (Tomoyuki Chikanaga) about 6 years ago

merge revision(s) 42439,42453: [Backport #8752]

* test/coverage/test_coverage.rb (TestCoverage#test_big_code): use `1'
  instead of `p' to get rid of a side effect.
  Kernel#p without any argument seems to do nothing, but flushes stdout.
  and, if stdout is redirected to file, fsync() will be called on
  Windows.  so, when running test-all on Windows with redirection, such
  as CI environment, this test took a lot of time.

History

#1

Updated by naruse (Yui NARUSE) about 6 years ago

r42453 も一緒にお願いします。

#2

Updated by nagachika (Tomoyuki Chikanaga) about 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r42492.
Usaku, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 42439,42453: [Backport #8752]

* test/coverage/test_coverage.rb (TestCoverage#test_big_code): use `1'
  instead of `p' to get rid of a side effect.
  Kernel#p without any argument seems to do nothing, but flushes stdout.
  and, if stdout is redirected to file, fsync() will be called on
  Windows.  so, when running test-all on Windows with redirection, such
  as CI environment, this test took a lot of time.

Also available in: Atom PDF