Backport #8752

please backport r42439

Added by Usaku NAKAMURA 8 months ago. Updated 8 months ago.

[ruby-dev:<unknown>]
Status:Closed
Priority:Normal
Assignee:Tomoyuki Chikanaga

Description

WindowsのCIで異様に時間がかかるtestがあるのですが、
実は無駄な時間消費なのでそれを改善するための変更です。

Associated revisions

Revision 42492
Added by Tomoyuki Chikanaga 8 months ago

merge revision(s) 42439,42453: [Backport #8752]

* test/coverage/test_coverage.rb (TestCoverage#test_big_code): use `1'
  instead of `p' to get rid of a side effect.
  Kernel#p without any argument seems to do nothing, but flushes stdout.
  and, if stdout is redirected to file, fsync() will be called on
  Windows.  so, when running test-all on Windows with redirection, such
  as CI environment, this test took a lot of time.

History

#1 Updated by Yui NARUSE 8 months ago

r42453 も一緒にお願いします。

#2 Updated by Tomoyuki Chikanaga 8 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r42492.
Usaku, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 42439,42453: [Backport #8752]

* test/coverage/test_coverage.rb (TestCoverage#test_big_code): use `1'
  instead of `p' to get rid of a side effect.
  Kernel#p without any argument seems to do nothing, but flushes stdout.
  and, if stdout is redirected to file, fsync() will be called on
  Windows.  so, when running test-all on Windows with redirection, such
  as CI environment, this test took a lot of time.

Also available in: Atom PDF