Project

General

Profile

Backport #8969

backport r43092 (call gc_rest_sweep on GC.disable)

Added by nagachika (Tomoyuki Chikanaga) almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
[ruby-dev:47736]

Description

r43092 は 2.0.0 でも必要でしょうか? 少なくとも無害でしょうか。
なんとなく GC を止めているところで LazySweep に絡んでいそうな問題の回避策になる気もするので、無害そうなら入れてみようかと思います。

Associated revisions

Revision 9eecfd5c
Added by nagachika (Tomoyuki Chikanaga) almost 6 years ago

merge revision(s) 43092: [Backport #8969]

    * gc.c (rb_gc_disable): do rest_sweep() before disable GC.
      This fix may solve a failure of
      TestTracepointObj#test_tracks_objspace_events
      [test/-ext-/tracepoint/test_tracepoint.rb:43].

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@43220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 43220
Added by nagachika (Tomoyuki Chikanaga) almost 6 years ago

merge revision(s) 43092: [Backport #8969]

* gc.c (rb_gc_disable): do rest_sweep() before disable GC.
  This fix may solve a failure of
  TestTracepointObj#test_tracks_objspace_events
  [test/-ext-/tracepoint/test_tracepoint.rb:43].

History

Updated by ko1 (Koichi Sasada) almost 6 years ago

2.1 で入れたのは、テストの都合だったりしますが、入れても害はありません(多分)。

#2

Updated by nagachika (Tomoyuki Chikanaga) almost 6 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43220.
Tomoyuki, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 43092: [Backport #8969]

* gc.c (rb_gc_disable): do rest_sweep() before disable GC.
  This fix may solve a failure of
  TestTracepointObj#test_tracks_objspace_events
  [test/-ext-/tracepoint/test_tracepoint.rb:43].

Updated by nagachika (Tomoyuki Chikanaga) almost 6 years ago

ruby_2_0_0 では gc_rest_sweep() -> rest_sweep() に名前を変更してバックポートしました。

Also available in: Atom PDF