Backport #9014: Import RubyGems 2.0.11 and 2.0.12

• Status: Closed
• Priority: Normal
• Assignee: Eric Hodel

[Eric Hodel]

This fixes the following bugs:

http://rubygems.rubyforge.org/rubygems-update/History_txt.html#label-2.0.12+%2F+2013-10-14

[Eric Hodel]

• File rubygems.2_0_11.2_0_12.ruby.2_0_0.patch View added
• Subject changed from Import RubyGems 2.0.11 to Import RubyGems 2.0.11 and 2.0.12
• Description updated (diff)

This updated patch updates ruby_2_0_0 branch to 2.0.12 from 2.0.10. It contains both rubygems 2.0.11 and 2.0.12 changes.

[Tomoyuki Chikanaga]

• Assignee changed from Tomoyuki Chikanaga to Eric Hodel

Hello,

With rubygems.2_0_11.2_0_12.ruby.2_0_0.patch, make test-all TESTS=rubygems report 3 failures on my environment.

[ 835/1347] TestGemRemoteFetcher#test_ssl_connection_allow_verify_none = 0.20 s

1) Error:
test_ssl_connection_allow_verify_none(TestGemRemoteFetcher):
OpenSSL::X509::StoreError:
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:451:in add_file'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:451:inblock in add_rubygems_trusted_certs'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:450:in each'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:450:inadd_rubygems_trusted_certs'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:437:in configure_connection_for_https'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:412:inconnection_for'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:495:in request'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:236:infetch_http'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:271:in fetch_path'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/test/rubygems/test_gem_remote_fetcher.rb:845:inblock in test_ssl_connection_allow_verify_none'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/test/rubygems/test_gem_remote_fetcher.rb:867:in with_configured_fetcher'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/test/rubygems/test_gem_remote_fetcher.rb:844:intest_ssl_connection_allow_verify_none'

[ 859/1347] TestGemRemoteFetcher#test_do_not_allow_insecure_ssl_connection_by_default = 0.13 s
2) Failure:
test_do_not_allow_insecure_ssl_connection_by_default(TestGemRemoteFetcher) [/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/test/rubygems/test_gem_remote_fetcher.rb:836]:
[Gem::RemoteFetcher::FetchError] exception expected, not
Class: OpenSSL::X509::StoreError
Message: <"">
---Backtrace---
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:451:in add_file'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:451:inblock in add_rubygems_trusted_certs'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:450:in each'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:450:inadd_rubygems_trusted_certs'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:437:in configure_connection_for_https'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:412:inconnection_for'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:495:in request'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:236:infetch_http'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:271:in `fetch_path'

/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/test/rubygems/test_gem_remote_fetcher.rb:837:in `block (2 levels) in test_do_not_allow_insecure_ssl_connection_by_default'

[ 862/1347] TestGemRemoteFetcher#test_do_not_follow_insecure_redirect = 0.18 s

3) Failure:
test_do_not_follow_insecure_redirect(TestGemRemoteFetcher) [/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/test/rubygems/test_gem_remote_fetcher.rb:853]:
[Gem::RemoteFetcher::FetchError] exception expected, not
Class: OpenSSL::X509::StoreError
Message: <"">
---Backtrace---
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:451:in add_file'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:451:inblock in add_rubygems_trusted_certs'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:450:in each'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:450:inadd_rubygems_trusted_certs'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:437:in configure_connection_for_https'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:412:inconnection_for'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:495:in request'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:236:infetch_http'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:271:in `fetch_path'

/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/test/rubygems/test_gem_remote_fetcher.rb:854:in `block (2 levels) in test_do_not_follow_insecure_redirect'

Finished tests in 92.790492s, 14.5166 tests/s, 47.0630 assertions/s.

1347 tests, 4367 assertions, 2 failures, 1 errors, 0 skips

ruby -v: ruby 2.0.0p335 (2013-10-11 revision 43242) [x86_64-darwin12.5.0]

[Tomoyuki Chikanaga]

It seems that X509_LOOKUP_load_file() return error in ossl_x509store_add_file (OpenSSL::X509::Store#add_file).
The PEM files following are empty file. Should I remove them?

lib/rubygems/ssl_certs/AddTrustExternalCARoot.pem
lib/rubygems/ssl_certs/Entrust_net-Secure-Server-Certification-Authority.pem
lib/rubygems/ssl_certs/GeoTrust_Global_CA.pem
lib/rubygems/ssl_certs/VerisignClass3PublicPrimaryCertificationAuthority-G2.pem
lib/rubygems/ssl_certs/ca-bundle.pem

[Eric Hodel]

Yes, they should be deleted. I guess svn diff does not include this information. Sorry for my delay in responding.

[Tomoyuki Chikanaga]

Thank you! I'll merge it.

[Tomoyuki Chikanaga]

• Status changed from Assigned to Closed
• % Done changed from 0 to 100

This issue was solved with changeset r43416.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.

---

• lib/rubygems: Update to RubyGems 2.0.12. [Backport #9014] the patch is provided by drbrain (Eric Hodel).