Backport #9014

Import RubyGems 2.0.11 and 2.0.12

Added by Eric Hodel 6 months ago. Updated 6 months ago.

[ruby-core:57818]
Status:Closed
Priority:Normal
Assignee:Eric Hodel

rubygems.2_0_11.ruby.2_0_0.patch Magnifier (239 KB) Eric Hodel, 10/11/2013 09:06 AM

rubygems.2_0_11.2_0_12.ruby.2_0_0.patch Magnifier (243 KB) Eric Hodel, 10/15/2013 07:35 AM

Associated revisions

Revision 43416
Added by Tomoyuki Chikanaga 6 months ago

  • lib/rubygems: Update to RubyGems 2.0.12. [Backport #9014] the patch is provided by drbrain (Eric Hodel).

History

#1 Updated by Eric Hodel 6 months ago

This updated patch updates ruby20_0 branch to 2.0.12 from 2.0.10. It contains both rubygems 2.0.11 and 2.0.12 changes.

#2 Updated by Tomoyuki Chikanaga 6 months ago

  • Assignee changed from Tomoyuki Chikanaga to Eric Hodel

Hello,

With rubygems.2011.2012.ruby.200.patch, make test-all TESTS=rubygems report 3 failures on my environment.

[ 835/1347] TestGemRemoteFetcher#testsslconnectionallowverifynone = 0.20 s

1) Error:
test
sslconnectionallowverifynone(TestGemRemoteFetcher):
OpenSSL::X509::StoreError:
/Users/nagachika/opt/ruby-2.0.0/src/ruby200/lib/rubygems/remotefetcher.rb:451:in add_file'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:451:in
block in addrubygemstrustedcerts'
/Users/nagachika/opt/ruby-2.0.0/src/ruby
200/lib/rubygems/remotefetcher.rb:450:in each'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:450:in
add
rubygemstrustedcerts'
/Users/nagachika/opt/ruby-2.0.0/src/ruby200/lib/rubygems/remotefetcher.rb:437:in configure_connection_for_https'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:412:in
connectionfor'
/Users/nagachika/opt/ruby-2.0.0/src/ruby
200/lib/rubygems/remotefetcher.rb:495:in request'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:236:in
fetch
http'
/Users/nagachika/opt/ruby-2.0.0/src/ruby200/lib/rubygems/remotefetcher.rb:271:in fetch_path'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/test/rubygems/test_gem_remote_fetcher.rb:845:in
block in testsslconnectionallowverifynone'
/Users/nagachika/opt/ruby-2.0.0/src/ruby
200/test/rubygems/testgemremotefetcher.rb:867:in with_configured_fetcher'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/test/rubygems/test_gem_remote_fetcher.rb:844:in
test
sslconnectionallowverifynone'

[ 859/1347] TestGemRemoteFetcher#testdonotallowinsecuresslconnectionbydefault = 0.13 s
2) Failure:
testdonotallowinsecuresslconnectionbydefault(TestGemRemoteFetcher) [/Users/nagachika/opt/ruby-2.0.0/src/ruby200/test/rubygems/testgemremotefetcher.rb:836]:
[Gem::RemoteFetcher::FetchError] exception expected, not
Class: OpenSSL::X509::StoreError
Message: <"">
---Backtrace---
/Users/nagachika/opt/ruby-2.0.0/src/ruby200/lib/rubygems/remotefetcher.rb:451:in add_file'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:451:in
block in addrubygemstrustedcerts'
/Users/nagachika/opt/ruby-2.0.0/src/ruby
200/lib/rubygems/remotefetcher.rb:450:in each'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:450:in
add
rubygemstrustedcerts'
/Users/nagachika/opt/ruby-2.0.0/src/ruby200/lib/rubygems/remotefetcher.rb:437:in configure_connection_for_https'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:412:in
connectionfor'
/Users/nagachika/opt/ruby-2.0.0/src/ruby
200/lib/rubygems/remotefetcher.rb:495:in request'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:236:in
fetch
http'
/Users/nagachika/opt/ruby-2.0.0/src/ruby200/lib/rubygems/remotefetcher.rb:271:in `fetch_path'

/Users/nagachika/opt/ruby-2.0.0/src/ruby200/test/rubygems/testgemremotefetcher.rb:837:in `block (2 levels) in testdonotallowinsecuresslconnectionbydefault'

[ 862/1347] TestGemRemoteFetcher#testdonotfollowinsecureredirect = 0.18 s

3) Failure:
test
donotfollowinsecureredirect(TestGemRemoteFetcher) [/Users/nagachika/opt/ruby-2.0.0/src/ruby200/test/rubygems/testgemremotefetcher.rb:853]:
[Gem::RemoteFetcher::FetchError] exception expected, not
Class: OpenSSL::X509::StoreError
Message: <"">
---Backtrace---
/Users/nagachika/opt/ruby-2.0.0/src/ruby200/lib/rubygems/remotefetcher.rb:451:in add_file'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:451:in
block in addrubygemstrustedcerts'
/Users/nagachika/opt/ruby-2.0.0/src/ruby
200/lib/rubygems/remotefetcher.rb:450:in each'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:450:in
add
rubygemstrustedcerts'
/Users/nagachika/opt/ruby-2.0.0/src/ruby200/lib/rubygems/remotefetcher.rb:437:in configure_connection_for_https'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:412:in
connectionfor'
/Users/nagachika/opt/ruby-2.0.0/src/ruby
200/lib/rubygems/remotefetcher.rb:495:in request'
/Users/nagachika/opt/ruby-2.0.0/src/ruby_2_0_0/lib/rubygems/remote_fetcher.rb:236:in
fetch
http'
/Users/nagachika/opt/ruby-2.0.0/src/ruby200/lib/rubygems/remotefetcher.rb:271:in `fetch_path'

/Users/nagachika/opt/ruby-2.0.0/src/ruby200/test/rubygems/testgemremotefetcher.rb:854:in `block (2 levels) in testdonotfollowinsecure_redirect'

Finished tests in 92.790492s, 14.5166 tests/s, 47.0630 assertions/s.

1347 tests, 4367 assertions, 2 failures, 1 errors, 0 skips

ruby -v: ruby 2.0.0p335 (2013-10-11 revision 43242) [x86_64-darwin12.5.0]

#3 Updated by Tomoyuki Chikanaga 6 months ago

It seems that X509LOOKUPloadfile() return error in osslx509storeaddfile (OpenSSL::X509::Store#add_file).
The PEM files following are empty file. Should I remove them?

lib/rubygems/sslcerts/AddTrustExternalCARoot.pem
lib/rubygems/ssl
certs/Entrustnet-Secure-Server-Certification-Authority.pem
lib/rubygems/ssl
certs/GeoTrustGlobalCA.pem
lib/rubygems/sslcerts/VerisignClass3PublicPrimaryCertificationAuthority-G2.pem
lib/rubygems/ssl
certs/ca-bundle.pem

#4 Updated by Eric Hodel 6 months ago

Yes, they should be deleted. I guess svn diff does not include this information. Sorry for my delay in responding.

#5 Updated by Tomoyuki Chikanaga 6 months ago

Thank you! I'll merge it.

#6 Updated by Tomoyuki Chikanaga 6 months ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r43416.
Eric, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


  • lib/rubygems: Update to RubyGems 2.0.12. [Backport #9014] the patch is provided by drbrain (Eric Hodel).

Also available in: Atom PDF