https://bugs.ruby-lang.org/https://bugs.ruby-lang.org/favicon.ico?17113305112013-11-28T21:26:09ZRuby Issue Tracking SystemRuby master - Bug #9172: siphash faulty on arm little endian with word align - missing codehttps://bugs.ruby-lang.org/issues/9172?journal_id=432272013-11-28T21:26:09Zzzak (zzak _)
<ul><li><strong>Status</strong> changed from <i>Open</i> to <i>Assigned</i></li><li><strong>Assignee</strong> set to <i>nobu (Nobuyoshi Nakada)</i></li></ul><p>nobu what do you think?</p>
<p>what is "collision.rb"?</p> Ruby master - Bug #9172: siphash faulty on arm little endian with word align - missing codehttps://bugs.ruby-lang.org/issues/9172?journal_id=432302013-11-28T22:53:45Zmame (Yusuke Endoh)mame@ruby-lang.org
<ul></ul><p>I confirmed the issue on my BeagleBone Black.</p>
<pre><code>$ ./miniruby -ve 'p ["discoverer".hash, "sub-setter".hash]'
ruby 2.1.0dev (2013-11-28 trunk 43540) [armv7l-linux-eabihf]
[-51053038, -51053038]
</code></pre>
<p>I think this is a bug of the siphash-c upstream:</p>
<p><a href="https://github.com/emboss/siphash-c/blob/master/src/siphash.c#L450" class="external">https://github.com/emboss/siphash-c/blob/master/src/siphash.c#L450</a></p>
<p>The bug was introduced by nobu, interestingly.</p>
<p><a href="https://github.com/emboss/siphash-c/commit/99ff3a058ffe3acc25dbadea6c053a74b73559e2" class="external">https://github.com/emboss/siphash-c/commit/99ff3a058ffe3acc25dbadea6c053a74b73559e2</a></p>
<p>--<br>
Yusuke Endoh <a href="mailto:mame@tsg.ne.jp" class="email">mame@tsg.ne.jp</a></p> Ruby master - Bug #9172: siphash faulty on arm little endian with word align - missing codehttps://bugs.ruby-lang.org/issues/9172?journal_id=432752013-11-30T13:28:16Znobu (Nobuyoshi Nakada)nobu@ruby-lang.org
<ul><li><strong>Status</strong> changed from <i>Assigned</i> to <i>Closed</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>This issue was solved with changeset r43928.<br>
Alban, thank you for reporting this issue.<br>
Your contribution to Ruby is greatly appreciated.<br>
May Ruby be with you.</p>
<hr>
<p>siphash.c: fix missing condition</p>
<ul>
<li>siphash.c (sip_hash24): fix for aligned word access little endian<br>
platforms. <a href="/issues/9172">[ruby-core:58658]</a> [Bug <a class="issue tracker-1 status-5 priority-4 priority-default closed" title="Bug: siphash faulty on arm little endian with word align - missing code (Closed)" href="https://bugs.ruby-lang.org/issues/9172">#9172</a>]</li>
</ul> Ruby master - Bug #9172: siphash faulty on arm little endian with word align - missing codehttps://bugs.ruby-lang.org/issues/9172?journal_id=538772015-08-20T06:00:42Zvo.x (Vit Ondruch)v.ondruch@tiscali.cz
<ul><li><strong>Backport</strong> changed from <i>1.9.3: UNKNOWN, 2.0.0: UNKNOWN</i> to <i>2.0.0: REQUIRED, 2.1: DONTNEED, 2.2: DONTNEED</i></li></ul>