Project

General

Profile

Backport #9232

Please Backport Bug #7239 to Ruby 1.9.3

Added by ryanatball (Ryan Melton) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:59000]

Description

This bug prevents backticks and popen from working correctly on Windows with Ruby 1.9.3. It was patched in 2.0 but not in 1.9.3. Please backport.


Related issues

Related to Ruby trunk - Bug #7239: Can't read from subprocess when run with rubyw on windowsClosed10/29/2012Actions

Associated revisions

Revision 8f83a5ee
Added by usa (Usaku NAKAMURA) over 5 years ago

merge revision(s) 37388: [Backport #9232]

    * process.c (redirect_dup2): set standard handles when new fd is stdio,
      because if there is no allocated console at the moment Windows does
      not automatically associate it for child process's standard handle.
      this is adhoc workaround.
      reported by Martin Thiede at [ruby-core:48542] [Bug #7239].

    * io.c (rb_cloexec_dup2): ditto.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@44338 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 44338
Added by usa (Usaku NAKAMURA) over 5 years ago

merge revision(s) 37388: [Backport #9232]

* process.c (redirect_dup2): set standard handles when new fd is stdio,
  because if there is no allocated console at the moment Windows does
  not automatically associate it for child process's standard handle.
  this is adhoc workaround.
  reported by Martin Thiede at [ruby-core:48542] [Bug #7239].

* io.c (rb_cloexec_dup2): ditto.

History

#1

Updated by sorah (Sorah Fukumori) over 5 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby trunk to Backport193
  • Category deleted (platform/windows)
  • Status changed from Open to Assigned
  • Assignee changed from luislavena (Luis Lavena) to usa (Usaku NAKAMURA)

Moving to correct project, and assigning to branch maintainer.

#2

Updated by usa (Usaku NAKAMURA) over 5 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

This issue was solved with changeset r44338.
Ryan, thank you for reporting this issue.
Your contribution to Ruby is greatly appreciated.
May Ruby be with you.


merge revision(s) 37388: [Backport #9232]

* process.c (redirect_dup2): set standard handles when new fd is stdio,
  because if there is no allocated console at the moment Windows does
  not automatically associate it for child process's standard handle.
  this is adhoc workaround.
  reported by Martin Thiede at [ruby-core:48542] [Bug #7239].

* io.c (rb_cloexec_dup2): ditto.

Also available in: Atom PDF