Project

General

Profile

Actions

Backport #9270

closed

Array#to_h should not ignore badly formed elements

Added by marcandre (Marc-Andre Lafortune) almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:59235]

Description

The upcoming Array#to_h feature currently ignores elements that are not 2-elements arrays. Array#to_h could instead raise an error on those elements. I argued otherwise before, but maybe that would be safer.

One reason I think I was wrong is that current form could encourage code like:

enum.map{|x| [x.foo, x.bar] if x.baz? }.to_h

using the fact that any nil will be ignored. I'm not sure that it's a good idea.

It would probably be safer to raise an Exception for elements that are not a key-value pair. It also satisfies fail-early principle.

@sawa (Tsuyoshi Sawada) agrees with this.
@matz (Yukihiro Matsumoto) agrees with the change.

Since this feature has not already been released in an official version, changing this behavior now would not cause any incompatibility and there should be no risk of regression. Changing this feature after the official 2.1 release would be more problematic as it could cause incompatibilities.

Yui, could you please confirm that there is no problem on your end for me to commit the following patch: https://github.com/marcandre/ruby/compare/to_h_raise


Related issues 1 (0 open1 closed)

Related to Ruby master - Feature #9239: Array#to_h ignores flat arraysRejectednaruse (Yui NARUSE)12/11/2013Actions
Actions

Also available in: Atom PDF