Project

General

Profile

Backport #9288

Cygwin 2.1.0 fix to 2.0.0

Added by dajoen (Jeroen Verhoeven) over 5 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:59283]

Description

Using RVM we see that ruby fails to compile for 1.9.3 and 2.0.0. This seems to be fixed in 2.1.0.
Compiling the 2.1.0 as follows succeeds:
rvm --debug install 2.1.0 --without-tcl --without-tk

Trying the same for 2.0.0 fails. With errors logged in the following gist: https://gist.github.com/dajoen/8094203

A history of events can also be seen in https://github.com/wayneeseguin/rvm/issues/2360.

Associated revisions

Revision 0d2b4a6d
Added by nagachika (Tomoyuki Chikanaga) over 5 years ago

merge revision(s) r43583: [Backport #9288]

    * file.c (GetLastError): already defined in windows.h on nowadays
      cygwin, and caused the confliction with the system provided
      definition on cygwin64.  by @kou1okada [Fixes GH-433].

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_0_0@44905 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 44905
Added by nagachika (Tomoyuki Chikanaga) over 5 years ago

merge revision(s) r43583: [Backport #9288]

* file.c (GetLastError): already defined in windows.h on nowadays
  cygwin, and caused the confliction with the system provided
  definition on cygwin64.  by @kou1okada [Fixes GH-433].

History

Updated by nagachika (Tomoyuki Chikanaga) over 5 years ago

  • Status changed from Open to Assigned
  • Assignee set to nagachika (Tomoyuki Chikanaga)
  • ruby -v set to 2.0.0p353

Thank you for your reporting.

r43583 seems related this issue. I'll backport it.

Updated by nagachika (Tomoyuki Chikanaga) over 5 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r44905.


merge revision(s) r43583: [Backport #9288]

* file.c (GetLastError): already defined in windows.h on nowadays
  cygwin, and caused the confliction with the system provided
  definition on cygwin64.  by @kou1okada [Fixes GH-433].

Also available in: Atom PDF