Project

General

Profile

Backport #9368

Typo in documentation of REXML.entity_expansion_text_limit=

Added by herwinw (Herwin Quarantainenet) almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:59587]

Description

In the module rexml/document there are a number of ways to change the variable @@entity_expansion_limit. The default value for this in the code is 10_000 (line 208 in the used version). The deprecated method Document::entity_expansion_text_limit= has a comment that says the default is 10240.

I haven't look at version 2.0 and above, so I'm not sure if these problems still exist in there.


Files

Associated revisions

Revision 672deabc
Added by usa (Usaku NAKAMURA) over 5 years ago

merge revision(s) 39388: [Backport #9368]

    * lib/rexml/document.rb (REXML::Document.entity_expansion_text_limit):
      fix a typo in comment in r39384.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_1_9_3@44735 b2dd03c8-39d4-4d8f-98ff-823fe69b080e

Revision 44735
Added by usa (Usaku NAKAMURA) over 5 years ago

merge revision(s) 39388: [Backport #9368]

* lib/rexml/document.rb (REXML::Document.entity_expansion_text_limit):
  fix a typo in comment in r39384.

History

Updated by kou (Kouhei Sutou) almost 6 years ago

  • Assignee set to usa (Usaku NAKAMURA)

Thanks for your report!
It had been fixed in r39388. The fix had been merged in 2.0.0 but not in 1.9.3.

usa, could you confirm it?

#2

Updated by usa (Usaku NAKAMURA) almost 6 years ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby master to Backport193
  • Status changed from Open to Assigned

Updated by usa (Usaku NAKAMURA) over 5 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r44735.


merge revision(s) 39388: [Backport #9368]

* lib/rexml/document.rb (REXML::Document.entity_expansion_text_limit):
  fix a typo in comment in r39384.

Also available in: Atom PDF