Backport #9368

Typo in documentation of REXML.entity_expansion_text_limit=

Added by Herwin . over 1 year ago. Updated over 1 year ago.

[ruby-core:59587]
Status:Closed
Priority:Normal
Assignee:Usaku NAKAMURA

Description

In the module rexml/document there are a number of ways to change the variable @@entity_expansion_limit. The default value for this in the code is 10_000 (line 208 in the used version). The deprecated method Document::entity_expansion_text_limit= has a comment that says the default is 10240.

I haven't look at version 2.0 and above, so I'm not sure if these problems still exist in there.

ruby-1.9.3-p484-typo_fix_rexml_entity_expansion_text_limit.diff Magnifier - patch (486 Bytes) Herwin ., 01/06/2014 06:32 PM

Associated revisions

Revision 44735
Added by Usaku NAKAMURA over 1 year ago

merge revision(s) 39388: [Backport #9368]

* lib/rexml/document.rb (REXML::Document.entity_expansion_text_limit):
  fix a typo in comment in r39384.

History

#1 Updated by Kouhei Sutou over 1 year ago

  • Assignee set to Usaku NAKAMURA

Thanks for your report!
It had been fixed in r39388. The fix had been merged in 2.0.0 but not in 1.9.3.

usa, could you confirm it?

#2 Updated by Usaku NAKAMURA over 1 year ago

  • Tracker changed from Bug to Backport
  • Project changed from Ruby trunk to Backport193
  • Status changed from Open to Assigned

#3 Updated by Usaku NAKAMURA over 1 year ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r44735.


merge revision(s) 39388: [Backport #9368]

* lib/rexml/document.rb (REXML::Document.entity_expansion_text_limit):
  fix a typo in comment in r39384.

Also available in: Atom PDF