Project

General

Profile

Backport #9844

Backport r45947, r45951

Added by Hiroshi Shirosaki over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
[ruby-core:62611]

Description

Fix machine stack overflow handling on mingw. See #9739.
r45947, r45951

Associated revisions

Revision 46522
Added by Tomoyuki Chikanaga over 2 years ago

merge revision(s) r45947,r45951: [Backport #9739] [Backport #9844]

* thread_win32.c (rb_w32_stack_overflow_handler): use Structured
  Exception Handling by Addvectoredexceptionhandler() for machine
  stack overflow on mingw.
  This would be equivalent to the handling using __try and __exept
  on mswin introduced by r43748.
  Exception Handling by AddVectoredExceptionHandler() for machine
  This would be equivalent to the handling using __try and __except

History

#1 [ruby-core:62987] Updated by Luis Lavena over 2 years ago

  • Status changed from Open to Assigned
  • Assignee set to Tomoyuki Chikanaga

#2 [ruby-core:62999] Updated by Luis Lavena over 2 years ago

Tomoyuki Chikanaga, can you apply those revisions to ruby_2_1 branch?

This is part of the last 2 issues holding 2.1.x release of RubyInstaller, so want to ensure are backported before any new release.

Thank you.

#3 [ruby-core:63195] Updated by Luis Lavena over 2 years ago

Tomoyuki Chikanaga, do you want us create patch/pull request with the modifications?

Will be great to have this backported before next release of 2.1

Thank you.

#4 [ruby-core:63298] Updated by Tomoyuki Chikanaga over 2 years ago

  • Status changed from Assigned to Closed
  • % Done changed from 0 to 100

Applied in changeset r46522.


merge revision(s) r45947,r45951: [Backport #9739] [Backport #9844]

* thread_win32.c (rb_w32_stack_overflow_handler): use Structured
  Exception Handling by Addvectoredexceptionhandler() for machine
  stack overflow on mingw.
  This would be equivalent to the handling using __try and __exept
  on mswin introduced by r43748.
  Exception Handling by AddVectoredExceptionHandler() for machine
  This would be equivalent to the handling using __try and __except

Also available in: Atom PDF