Project

General

Profile

Activity

From 11/24/2011 to 12/23/2011

12/23/2011

08:20 PM Backport #5518: Please backport r33577 (mingw: append -fno-omit-frame-pointer)
Hello,
Anyone can take a look to this and let me know? For convenience and review, the following is the patch I wa...
Luis Lavena
05:32 PM Backport #5539 (Open): Readline.readline() blocks all threads
Please backport r34108 to ruby_1_9_3
Kouji Takao
04:02 PM Backport #5539 (Closed): Readline.readline() blocks all threads
This issue was solved with changeset r34108.
Christopher, thank you for reporting this issue.
Your contribution to Ru...
Kouji Takao
05:31 PM Backport #4635 (Open): Readline.completion_append_character
Please backport r34109 to ruby_1_9_3
Kouji Takao
04:38 PM Backport #4635 (Closed): Readline.completion_append_character
This issue was solved with changeset r34109.
Nobuhiro, thank you for reporting this issue.
Your contribution to Ruby ...
Kouji Takao
02:23 AM Backport #4635: Readline.completion_append_character
高尾です。

On 2011/12/22, at 22:52, Nobuhiro IMAI wrote:
> From: Nobuyoshi Nakada <nobu_at_ruby-lang.org>
> Date: We...
Kouji Takao
01:50 AM Backport #5791: Please backport r34043, r34045 (Unexpected error of STDIN#read with non-ascii input)
FYI, a pre-backported version is being maintained on https://github.com/thecodeshop/ruby/commits/winio/ruby_1_9_3/ Jon Forums
01:22 AM Backport #5791 (Closed): Please backport r34043, r34045 (Unexpected error of STDIN#read with non-...
Please backport r34043 and it's fixup r34045 to ruby_1_9_3. Jon Forums
01:49 AM Backport #5792: Please backport r33946, r33981 (Use GZip::GzReader.open instead of GZip::GzReader...
FYI, a pre-backported version is being maintained on https://github.com/thecodeshop/ruby/commits/winio/ruby_1_9_3/ Jon Forums
01:25 AM Backport #5792 (Closed): Please backport r33946, r33981 (Use GZip::GzReader.open instead of GZip:...
Please backport r33946 and the related r33981 to ruby_1_9_3. Jon Forums
01:48 AM Backport #5793: Please backport r33662, r33666 (ECONV_NEWLINE_DECORATOR_{READ,WRITE}_MASK)
FYI, a pre-backported version is being maintained on https://github.com/thecodeshop/ruby/commits/winio/ruby_1_9_3/ Jon Forums
01:27 AM Backport #5793 (Closed): Please backport r33662, r33666 (ECONV_NEWLINE_DECORATOR_{READ,WRITE}_MASK)
Please backport r33662 and it's fixup r33666 to ruby_1_9_3. Jon Forums
01:46 AM Backport #5794 (Closed): Please backport r33200 (transcode.c: enabled econv newline option)
Please backport r33200 to ruby_1_9_3.
FYI, a pre-backported version is being maintained on https://github.com/thec...
Jon Forums
01:17 AM Backport #5704: Please backport r33937 (newline decorator)
Please ensure the r33944 fixup patch for this issue is also backported. Jon Forums

12/22/2011

10:53 PM Backport #4635: Readline.completion_append_character
いまいです。

From: Nobuyoshi Nakada <nobu_at_ruby-lang.org>
Date: Wed, 21 Dec 2011 17:06:48 +0900

> もうちょっとシンプル...
Nobuhiro IMAI
10:47 PM Backport #5757 (Closed): main threadがreadやselectで待っていると、^C でなかなか死なない
Tomoyuki Chikanaga
10:47 PM Backport #5757: main threadがreadやselectで待っていると、^C でなかなか死なない
確認ありがとうございます。 r34099 でコミットしました。 Tomoyuki Chikanaga
01:35 AM Backport #5757: main threadがreadやselectで待っていると、^C でなかなか死なない
しばらく考えた結果、[ruby-dev:44999] のパッチで問題ないという結論に至りました。コミットお願い出来ますでしょうか
Motohiro KOSAKI
10:23 AM Backport #5786: LoadError: cannot load such file -- openssl
なかだです。

(11/12/22 0:32), Kazuhiro NISHIYAMA wrote:
> % git grep -n 'autoload.*openssl'
> lib/net/htt...
Nobuyoshi Nakada
09:28 AM Backport #5786: LoadError: cannot load such file -- openssl
ええと。
ちゃんと読んでないのですが僕の理解が正しければ、 if defined? OpenSSL を使うのをやめて、テストの最初で require 'openssl' してみて例外投げてきたらスキップとかすればいい?
Motohiro KOSAKI
09:20 AM Backport #5786: LoadError: cannot load such file -- openssl
That's so nice of you to translate, thank you! Please let me know if and how I can help! Martin Bosslet
07:29 AM Backport #5786: LoadError: cannot load such file -- openssl
On Thu, Dec 22, 2011 at 00:32, Kazuhiro NISHIYAMA <redmine@ruby-lang.org> wrote:
> % git grep -n 'autoload.*openss...
Hiroshi Nakamura
12:32 AM Backport #5786: LoadError: cannot load such file -- openssl
% git grep -n 'autoload.*openssl'
lib/net/http.rb:24:autoload :OpenSSL, 'openssl'
%
で autoload が設定されていて、
...
Kazuhiro NISHIYAMA
12:26 AM Backport #5786 (Closed): LoadError: cannot load such file -- openssl
openssl がビルドされていないと test-all で LoadError: cannot load such file -- openssl になっていくつかエラーになります。
途中で Ctrl+C で止めてしまっているので...
Kazuhiro NISHIYAMA

12/21/2011

11:26 PM Backport #5757 (Assigned): main threadがreadやselectで待っていると、^C でなかなか死なない
すいません。なるべく早く時間取ってレビューします Motohiro KOSAKI
06:41 PM Backport #5757 (Open): main threadがreadやselectで待っていると、^C でなかなか死なない
[ruby-dev:44999] に書いたように今度はシグナル処理の漏れの懸念があるので再 open させて頂きます。 Tomoyuki Chikanaga
05:23 PM Backport #4635: Readline.completion_append_character
なかだです。

(11/04/30 14:40), Nobuhiro IMAI wrote:
> 影響範囲がよく分かっていませんが、Ruby の readline 側で
> rl_completion_append_...
Nobuyoshi Nakada

12/20/2011

06:52 AM Revision 34080: * 2011-12-20
svn
06:52 AM Revision 34079: * io.c: Improve rdoc for {File|IO}.write
Marc-Andre Lafortune

12/19/2011

02:13 AM Backport #5757 (Closed): main threadがreadやselectで待っていると、^C でなかなか死なない
This issue was solved with changeset r34038.
Yui, thank you for reporting this issue.
Your contribution to Ruby is gr...
Yui NARUSE

12/18/2011

02:01 AM Revision 34066: removing a file I accidentally added. :(
tenderlove

12/15/2011

01:45 AM Revision 34049: * 2011-12-15
svn
01:44 AM Revision 34048: * array.c (rb_ary_reject_bang, rb_ary_delete_if): update rdoc.
documentation from Thomas Leitner <t_leitner AT gmx.at> in
[ruby-core:41616]. [Bug #5752]
Nobuyoshi Nakada

12/14/2011

09:45 PM Backport #5757: main threadがreadやselectで待っていると、^C でなかなか死なない
Motohiro KOSAKI wrote:
> いや、スレッドがGVL競合してなくて、ubf_selectを登録したけどまだselectを読んでないとき
> ubf_selectのkill(VTALRM) はスカるので、もう一回...
Tomoyuki Chikanaga
03:23 PM Backport #5757: main threadがreadやselectで待っていると、^C でなかなか死なない
(2011/12/14 15:00), Yui NARUSE wrote:
> そのもう一回も外しちゃう可能性って無いんでしょうか。
> どちらかというと、rb_thread_kill 側で確実に止めを刺す用にするべきな気も...
Koichi Sasada
03:00 PM Backport #5757: main threadがreadやselectで待っていると、^C でなかなか死なない
レビューありがとうございます。
> いや、スレッドがGVL競合してなくて、ubf_selectを登録したけどまだselectを読んでないとき
> ubf_selectのkill(VTALRM) はスカるので、もう一回ubf_s...
Yui NARUSE
10:53 AM Backport #5757: main threadがreadやselectで待っていると、^C でなかなか死なない
2011年12月13日19:45 Tomoyuki Chikanaga <nagachika00@gmail.com>:
>
> Issue #5757 has been updated by Tomoyuki Chikanaga.
...
Motohiro KOSAKI
09:45 AM Backport #5757: main threadがreadやselectで待っていると、^C でなかなか死なない
Bug #5343 を登録したものです。
ちゃんと試さずに書いてしまいますが、 #5343 は別の Thread からの kill や raise での割り込みの場合の問題だったと記憶していますので、ubf_select() での ...
Tomoyuki Chikanaga
02:34 AM Backport #5757: main threadがreadやselectで待っていると、^C でなかなか死なない
[Bug #5343] (r33307) でのregressionですね(193ブランチだと r33310)。単純にそこを削除すると Bug #5343が復活してしまうので、タイマー貼る必要があるんじゃないですかね。タイマースレッドを... Motohiro KOSAKI
06:28 AM Revision 34042: * 2011-12-14
svn
06:28 AM Revision 34041: * transcode.c (str_encode): about the extension of :fallback
option since 1.9.3. Nobuyoshi Nakada
12:06 AM Backport #5755 (Open): Errors raised and rescued in Kernel#loaded file still propagate
Please backport r34028 and r34030. Tomoyuki Chikanaga

12/13/2011

11:56 PM Backport #5755 (Closed): Errors raised and rescued in Kernel#loaded file still propagate
This issue was solved with changeset r34030.
Nikolai, thank you for reporting this issue.
Your contribution to Ruby i...
Tomoyuki Chikanaga
12:24 PM Backport #5755 (Assigned): Errors raised and rescued in Kernel#loaded file still propagate
Thank you for your report.
I think this is a bug too.
I've found a bad usage of rb_protect() in name_err_mesg_to_...
Tomoyuki Chikanaga
10:17 AM Backport #5755 (Closed): Errors raised and rescued in Kernel#loaded file still propagate
a.rb:

load 'b.rb'

b.rb:

begin
BasicObject.new.inspect
rescue => e
p e
end

% ruby -v
...
Nikolai Weibull
04:35 PM Backport #5757 (Closed): main threadがreadやselectで待っていると、^C でなかなか死なない
FreeBSD 9 にて、 ./ruby と起動して ^C を投げてもなかなか死にません。
./miniruby でも -e'$stdin.read' でも同じです。
仕組みとしては、main thread が read や ...
Yui NARUSE
06:30 AM Backport #5753 (Closed): [Ripper] on_magic_comment doesn't pass proper value
This issue was solved with changeset r34022.
Nobuyoshi, thank you for reporting this issue.
Your contribution to Ruby...
Nobuyoshi Nakada
06:22 AM Backport #5753 (Closed): [Ripper] on_magic_comment doesn't pass proper value
=begin
$ ruby -v -rripper -e 'r = Ripper.new("# -*- foo: bar -*-"); def r.on_magic_comment(*x);p x;end;r.parse'
...
Nobuyoshi Nakada
02:47 AM Backport #5537 (Closed): Please backport Psych 1.2.2 update
I've backported this, so closing. Aaron Patterson

12/12/2011

08:49 PM Revision 34019: * test/dtrace/test_object_create.rb: property.
Nobuyoshi Nakada
05:47 PM Revision 34018: * 2011-12-13
svn
05:47 PM Revision 34017: merge revision(s) 33160,33381,33382,33383,33384,33385:
* ext/psych/lib/psych.rb: update psych version.
* ext/psych/psych.gemspec: generate new gemspec for new version.
...
tenderlove

12/09/2011

03:01 PM Backport #5733 (Closed): Error when loading a converter
This issue was solved with changeset r33991.
, thank you for reporting this issue.
Your contribution to Ruby is great...
Yui NARUSE
10:44 AM Backport #5733 (Closed): Error when loading a converter
I think this might be a bug, but I'm not sure. The following code
raises an exception:

# encoding:utf-8
...
Anonymous
09:43 AM Backport #5635: String#unpack("M") の不正データ時の振る舞い
あ~、なるほど、不正なデータに遭遇したら、それ以降のデータは一切変換するな…と。
確かにそっちの方がいいような気がします。
Masahiro Tomita
05:53 AM Backport #5723: Backport r33567 and r33573 (Ruby fails when standard input is closed)
Ruby is being forked as a subprocess by a service which runs on both windows and linux. With ruby 1.8, a closed STDI... Randal Moore

12/08/2011

11:48 PM Backport #5702: backport r33935, r33987 (fix private constant)
ありがとうございます。
テストを追加して r33987 でコミットしました。
Tomoyuki Chikanaga
09:23 PM Backport #5702: backport r33935, r33987 (fix private constant)
遠藤です。

本題の方、時間があいてしまってすみません。

2011年12月5日10:14 Tomoyuki Chikanaga <nagachika00@gmail.com>:
> そんなにコアじゃないですがレ...
Yusuke Endoh
08:53 PM Backport #5725: Coverage doesn't honor file path encodings
成瀬です。

(2011/12/08 20:40), Yusuke Endoh wrote:
> 2011/12/8, Shyouhei Urabe <shyouhei@ruby-lang.org>:
>> 以下のよ...
Yui NARUSE
08:53 PM Backport #5725: Coverage doesn't honor file path encodings
遠藤です。

2011/12/8, Shyouhei Urabe <shyouhei@ruby-lang.org>:
> 以下のように、カバレッジの出力がファイルパスのエンコーディングを無視しています。
> これのせ...
Yusuke Endoh
12:32 PM Backport #5725 (Closed): Coverage doesn't honor file path encodings
以下のように、カバレッジの出力がファイルパスのエンコーディングを無視しています。
これのせいでsimplecovがこけて気づきました。
https://gist.github.com/1445972
Shyouhei Urabe
03:52 AM Backport #5723: Backport r33567 and r33573 (Ruby fails when standard input is closed)
Backport r33567 and r33573. Nobuyoshi Nakada
02:26 AM Backport #5723: Backport r33567 and r33573 (Ruby fails when standard input is closed)
One question. Why don't you use /dev/null? Which behavior did you expected?
Thank you.
Motohiro KOSAKI
01:48 AM Backport #5723 (Closed): Backport r33567 and r33573 (Ruby fails when standard input is closed)
If the ruby process is launched with its standard input closed, it does not behave very well. The following output w... Randal Moore

12/07/2011

10:04 AM Revision 33972: * 2011-12-07
svn
10:04 AM Revision 33971: * configure.in (rpath): fix typo in the help string. a patch from
Yuji Yamano <yyamano AT kt.rim.or.jp> in [ruby-list:48568]. Nobuyoshi Nakada
08:45 AM Backport #5537: Please backport Psych 1.2.2 update
This patch looks OK to me. Eric Hodel
07:26 AM Backport #5537: Please backport Psych 1.2.2 update
Can someone please review this for backporting? I've attached a combined diff for these commits. Aaron Patterson
02:19 AM Backport #5704: Please backport r33937 (newline decorator)
FYI, in the hope that it helps with backporting, a branch containing Hiroshi's patch is being maintained at
https:...
Jon Forums

12/05/2011

04:53 PM Backport #5702: backport r33935, r33987 (fix private constant)
On 2011年12月05日 16:17, KOSAKI Motohiro wrote:
> 今回の件に限っていうと、ちょっとこのコメントははずしているような。

そうかもしれません。ごめんなさい。私がいいたかった事はま...
Shyouhei Urabe
04:23 PM Backport #5702: backport r33935, r33987 (fix private constant)
>> チケット作るなら簡単に内容を〜というは同意するのですが、
>> (というかコミットログコピペでいいはずではある)
>> そもそもバックポートチケットって受益者が作るべきなんじゃないかなぁとは思ったりも。
>
>...
Motohiro KOSAKI
03:53 PM Backport #5702: backport r33935, r33987 (fix private constant)
> 言い訳にしか聞こえませんが私が望んでいるのは「〜の件」と1行書いてほしい
> だけで詳細な説明は不要だと思います。どうせみんなcommit log 読んでるんだし。
> ChangeLogをカット&ペーストとかでも十分。...
Motohiro KOSAKI
03:53 PM Backport #5702: backport r33935, r33987 (fix private constant)
On 2011年12月05日 14:25, NARUSE, Yui wrote:
> 2011年12月5日12:39 Yusuke Endoh <mame@tsg.ne.jp>:
>> ただ、バックポートチケットを書く人に過...
Shyouhei Urabe
03:53 PM Backport #5702: backport r33935, r33987 (fix private constant)
Motohiro KOSAKI
02:29 PM Backport #5702: backport r33935, r33987 (fix private constant)
2011年12月5日12:39 Yusuke Endoh <mame@tsg.ne.jp>:
> ただ、バックポートチケットを書く人に過剰な期待をしないでという気持ち
> には変わりがありません。ある程度真面目に書かないとい...
Yui NARUSE
12:53 PM Backport #5702: backport r33935, r33987 (fix private constant)
Yusuke Endoh
12:43 PM Backport #5702: backport r33935, r33987 (fix private constant)
一度 make clean したら発生しなくなりました。
おさわがせしました。
Tomoyuki Chikanaga
10:56 AM Backport #5702: backport r33935, r33987 (fix private constant)
すみません、先程わたしが添付したパッチをあてると、なぜか Syck のテストが1つ Failure になってしまいました。後程調べるのでとりあえずこのパッチは差し戻させてください。 Tomoyuki Chikanaga
10:14 AM Backport #5702: backport r33935, r33987 (fix private constant)
近永です。
そんなにコアじゃないですがレビューしました。
* continue するよりは NameError 発生を else 節にしたほうが見通しが良いかと思います。好みの問題のような気もしますけど。
* また Na...
Tomoyuki Chikanaga

12/04/2011

10:35 AM Backport #5704 (Closed): Please backport r33937 (newline decorator)
Hello,
r33937 contains what was labeled 'feature' for ruby-trunk (Issue #5562), however, it was considered a bug a...
Luis Lavena
09:29 AM Backport #5702: backport r33935, r33987 (fix private constant)
遠藤です。

2011年12月4日3:19 KOSAKI Motohiro <kosaki.motohiro@gmail.com>:
>> r33886 を ruby_1_9_3 にバックポート希望です。
>> ([...
Yusuke Endoh
03:23 AM Backport #5702: backport r33935, r33987 (fix private constant)
> ----------------------------------------
> Backport #5702: backport r33935
> http://redmine.ruby-lang.org/issu...
Motohiro KOSAKI

12/03/2011

08:55 PM Backport #5702 (Closed): backport r33935, r33987 (fix private constant)
r33935 を ruby_1_9_3 にバックポート希望です。
([ruby-list:48558] のバグ修正)
誰かレビュー頼みます。
--
Yusuke Endoh <mame@tsg.ne.jp>
Yusuke Endoh
10:37 AM Backport #5700 (Closed): fork {} segfaults during VM cleanup when run inside Fiber
The issue is very easy to reproduce:
Fiber.new do
p Process.waitpid2(fork {})
end.resume
Parent process ...
Eric Wong

12/01/2011

11:55 PM Backport #5539: Readline.readline() blocks all threads
Takao san,
Is it hard to make time to take a look at this issue?
Thanks,
Tomoyuki Chikanaga
11:23 AM Backport #5646: Backport r33775
On Nov 30, 2011, at 17:35, Luis Lavena <luislavena@gmail.com> wrote:

> On Wed, Nov 30, 2011 at 10:27 PM, KOSAKI...
Eric Hodel
10:53 AM Backport #5646: Backport r33775
On Wed, Nov 30, 2011 at 10:27 PM, KOSAKI Motohiro
<kosaki.motohiro@gmail.com> wrote:
>
>> I also heard there is a...
Luis Lavena
10:29 AM Backport #5646: Backport r33775
>> > Also, is there a script for doing backports?  It looks like the commit messages are generated.
>>
>> I like ...
Motohiro KOSAKI
10:23 AM Backport #5646: Backport r33775
On Thu, Dec 01, 2011 at 02:19:31AM +0900, KOSAKI Motohiro wrote:
> > Also, is there a script for doing backports?  ...
Anonymous
02:23 AM Backport #5646: Backport r33775
> Also, is there a script for doing backports?  It looks like the commit messages are generated.

I like tool/mer...
Motohiro KOSAKI

11/30/2011

06:23 PM Backport #5546 (Closed): Bus error in Complex.rationalize
This issue was solved with changeset r33907.
Dave, thank you for reporting this issue.
Your contribution to Ruby is g...
Yui NARUSE
11:53 AM Backport #5621: Please backport thread-safe autoloading patch
Yehuda Katz
(ph) 718.877.1325


On Tue, Nov 29, 2011 at 2:43 AM, Charles Oliver Nutter
<headius@headius.co...
Yehuda Katz
09:23 AM Revision 33907: merge revision(s) r33613:
* complex.c (nucomp_rationalize): fix function. [ruby-core:40667]
[Bug #5546]
Yui NARUSE
09:22 AM Backport #5646 (Closed): Backport r33775
Sorry for the delay. I backported this commit, can someone please check to make sure I didn't make a mistake?
Als...
Aaron Patterson
05:09 AM Backport #5635: String#unpack("M") の不正データ時の振る舞い
わたしには処理を継続しないと読めるんですがどうなんでしょう。
まぁ、RFCよりもこの手の通信系は長いものに巻かれるのが正しい気もするので、他の実装の例でも。
Yui NARUSE
03:04 AM Backport #5276 (Closed): 4294967295.8.round is 4294967295 on 32bit
This issue was solved with changeset r33899.
Yui, thank you for reporting this issue.
Your contribution to Ruby is gr...
Yui NARUSE
02:39 AM Backport #5272 (Closed): Float#round doesn't round big values
This issue was solved with changeset r33898.
Marc-Andre, thank you for reporting this issue.
Your contribution to Rub...
Yui NARUSE
02:29 AM Backport #5271 (Closed): Integer#round should never return a Float
This issue was solved with changeset r33897.
Marc-Andre, thank you for reporting this issue.
Your contribution to Rub...
Yui NARUSE
12:21 AM Revision 33903: merge revision(s) 33775:
* ext/psych/lib/psych.rb (load_file): make sure opened yaml files are
also closed. [ruby-core:41088]
tenderlove

11/29/2011

07:59 PM Backport #5621: Please backport thread-safe autoloading patch
On Tue, Nov 29, 2011 at 4:43 AM, Charles Oliver Nutter
<headius@headius.com> wrote:
> I think an additional warn...
Charles Nutter
07:53 PM Backport #5621: Please backport thread-safe autoloading patch
On Mon, Nov 21, 2011 at 4:18 AM, Hiroshi Nakamura <nahi@ruby-lang.org> wrote:
> I see.  Maybe I misunderstood 'a si...
Charles Nutter
06:04 PM Revision 33899: merge revision(s) 33198,33199:
* numeric.c (flo_round): Fix criteria for 32 bits platform
part 2 of [bug #5276]
* numeric.c (dbl2ival): Fix Flo...
Yui NARUSE
05:39 PM Revision 33898: merge revision(s) 33158,33185,33186:
* numeric.c (flo_round): substitute machine dependent magic number.
* numeric.c (flo_round): Make Float#round round...
Yui NARUSE
05:29 PM Revision 33897: merge revision(s) 33183,33185:
* numeric.c (int_round): Integer#round always returns an Integer [Bug
#5271]
Yui NARUSE
12:18 AM Backport #5682 (Closed): Backport r33886 (convert mdoc to man properly)
Please backport r33886 to ruby_1_9_3 Yuki Sonoda

11/24/2011

06:51 PM Backport #5668: autoconf failure on HP-UX/PA 11.11
I 've test on ruby-1.9.2-p290 and ruby-1.9.3-p0 hongbo hu
06:48 PM Backport #5668 (Rejected): autoconf failure on HP-UX/PA 11.11
$ ./configure
On HP-UX/PA:
checking whether _SC_CLK_TCK is supported... yes
checking stack growing direction on hp...
hongbo hu
12:35 PM Backport #5665: [PATCH] io.c (rb_io_fsync,rb_io_fdatasync): release GVL
r33826 Motohiro KOSAKI
02:51 AM Backport #5665 (Assigned): [PATCH] io.c (rb_io_fsync,rb_io_fdatasync): release GVL
Looks reasonable. I'll commit it.
Motohiro KOSAKI
 

Also available in: Atom