Project

General

Profile

« Previous | Next » 

Revision 10421fb1

Added by normal almost 7 years ago

IO#close: do not enqueue redundant interrupts (take #2)

Enqueuing multiple errors for one event causes spurious errors
down the line, as reported by Nikolay Vashchenko in
https://bugs.ruby-lang.org/issues/13632

This should fix bad interactions with test_race_gets_and_close
in test/ruby/test_io.rb since we ensure rb_notify_fd_close
continues returning the busy flag after enqueuing the interrupt.

Backporting changes to 2.4 and earlier releases will be more
challenging...

  • thread.c (rb_notify_fd_close): do not enqueue multiple interrupts
    [ruby-core:81581] [Bug #13632]
  • test/ruby/test_io.rb (test_single_exception_on_close):
    new test based on script from Nikolay

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@59028 b2dd03c8-39d4-4d8f-98ff-823fe69b080e