Project

General

Profile

Actions

Bug #10156

closed

Underquoted definition warning in configure.in

Added by luizluca (Luiz Angelo Daros de Luca) about 10 years ago. Updated about 10 years ago.

Status:
Closed
Target version:
ruby -v:
ruby 2.1.2p95 (2014-05-08 revision 45877) [x86_64-linux-gnu]
[ruby-core:64473]

Description

Hello,

I'm getting this warning when compiling ruby:

configure.in:696: warning: underquoted definition of RUBY_TRY_CFLAGS

Which contains:

 695 
 696 AC_DEFUN(RUBY_TRY_CFLAGS, [
 697     AC_MSG_CHECKING([whether ]$1[ is accepted as CFLAGS])
 698     RUBY_WERROR_FLAG([
 699     CFLAGS="[$]CFLAGS $1"
 700     AC_TRY_COMPILE([$4], [$5],
 701     [$2
 702     AC_MSG_RESULT(yes)],
 703     [$3
 704     AC_MSG_RESULT(no)])
 705     ])
 706 ])
 707 
 708 AC_DEFUN(RUBY_TRY_LDFLAGS, [

A quick google says that "AC_DEFUN(RUBY_TRY_CFLAGS,..." should
be "AC_DEFUN([RUBY_TRY_CFLAGS],...". Probably the same happens with
RUBY_TRY_LDFLAGS but it did not generated warnings for me (not called?).

I have no idea how to work with autoconf. Please, for anyone familiar with it,
this is an easy fix.

Updated by luizluca (Luiz Angelo Daros de Luca) about 10 years ago

Looking for usages, I found:

configure.in:AC_DEFUN([RUBY_PREREQ_AC],
configure.in:AC_DEFUN([RUBY_RM_RECURSIVE], [
configure.in:AC_DEFUN([RUBY_MINGW32],
configure.in:AC_DEFUN([RUBY_NACL],
configure.in:AC_DEFUN([RUBY_NACL_CHECK_PEPPER_TYPES],
configure.in:AC_DEFUN([RUBY_CPPOUTFILE],
configure.in:AC_DEFUN([RUBY_PROG_GNU_LD],
configure.in:AC_DEFUN([RUBY_APPEND_OPTION],
configure.in:AC_DEFUN([RUBY_APPEND_OPTIONS],
configure.in:AC_DEFUN([RUBY_PREPEND_OPTION],
configure.in:AC_DEFUN([RUBY_PREPEND_OPTIONS],
configure.in:AC_DEFUN([RUBY_DEFAULT_ARCH], [
configure.in:AC_DEFUN([RUBY_UNIVERSAL_ARCH], [
configure.in:AC_DEFUN([RUBY_DTRACE_AVAILABLE],
configure.in:AC_DEFUN([RUBY_DTRACE_POSTPROCESS],
configure.in:AC_DEFUN([RUBY_WERROR_FLAG], [dnl
configure.in:AC_DEFUN(RUBY_TRY_CFLAGS, [
configure.in:AC_DEFUN(RUBY_TRY_LDFLAGS, [
configure.in:AC_DEFUN([RUBY_CHECK_SIZEOF],
configure.in:AC_DEFUN([RUBY_CHECK_PRINTF_PREFIX], [
configure.in:AC_DEFUN([RUBY_CHECK_SIGNEDNESS], [dnl
configure.in:AC_DEFUN([RUBY_REPLACE_TYPE], [dnl
configure.in:AC_DEFUN([RUBY_DEFINE_IF], [dnl
configure.in:AC_DEFUN([RUBY_FUNC_ATTRIBUTE], [dnl
configure.in:AC_DEFUN([RUBY_DEFINT], [dnl
configure.in:AC_DEFUN([RUBY_CHECK_BUILTIN_FUNC], [dnl
configure.in:AC_DEFUN([RUBY_CHECK_VARTYPE], [dnl
configure.in:  AC_DEFUN([RUBY_CHECK_SYSCONF], [dnl
configure.in:AC_DEFUN(RUBY_STACK_GROW_DIRECTION, [

Only RUBY_TRY_CFLAGS, RUBY_TRY_LDFLAGS and RUBY_STACK_GROW_DIRECTION are different.

Updated by nobu (Nobuyoshi Nakada) about 10 years ago

  • Description updated (diff)
  • Status changed from Open to Feedback

What version do you use?
Autoconf 2.69 doesn't show that warning.

Updated by nobu (Nobuyoshi Nakada) about 10 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

Applied in changeset r47226.


configure.in: quote defun names

  • configure.in (RUBY_TRY_CFLAGS, RUBY_TRY_LDFLAGS),
    (RUBY_CHECK_BUILTIN_SETJMP, RUBY_SETJMP_TYPE),
    (RUBY_STACK_GROW_DIRECTION): quote defun names, for some
    versions of autoconf possibly. [ruby-core:64473] [Bug #10156]
Actions

Also available in: Atom PDF

Like0
Like0Like0Like0