Project

General

Profile

Actions

Bug #10551

closed

Unnecessary #undef in file.c

Added by shadeslayer (Rohan Garg) over 9 years ago. Updated over 9 years ago.

Status:
Closed
Assignee:
-
Target version:
-
ruby -v:
ruby 2.1.2p95 (2014-05-08) [x86_64-linux-gnu]
[ruby-core:66503]

Description

Hi there
I was just casually looking at the File locking implementation in ruby inside file.c and noticed that there's a unnecessary #undef flock at the end of the function, maybe it really is required, but I couldn't figure out why.

So here's my first patch to ruby, but I'm not totally sure about it. Feel free to correct me if I'm wrong and it really is required, git history didn't tell me much.


Files

remove_unnecessary_undef.patch (254 Bytes) remove_unnecessary_undef.patch shadeslayer (Rohan Garg), 11/27/2014 12:43 AM

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r48629.


file.c: unnecessary #undef

  • file.c (flock): remove unnecessary #undef flock, trace of green
    thread polling. patched by Rohan Garg. [Bug #10551]
Actions

Also available in: Atom PDF

Like0
Like0