Project

General

Profile

Actions

Feature #10806

closed

drop batch installation

Added by nobu (Nobuyoshi Nakada) over 9 years ago. Updated over 9 years ago.

Status:
Closed
Assignee:
-
Target version:
-
[ruby-core:67913]

Description

We have already dropped Windows 95 support a few years ago.
So I want to drop batch file installation too now.
Does anyone know other platforms using .bat files?

commit 1b39c6670064066b1fbf728bf8d9288491fbe246
Author: Nobuyoshi Nakada <nobu@ruby-lang.org>
Date:   Sat Jan 31 12:32:56 2015 +0900

    rbinstall.rb: no batch installation
    
    * tool/rbinstall.rb (bin-comm): drop batch file installation.
      Windows 95 support has not been supported already.

diff --git a/tool/rbinstall.rb b/tool/rbinstall.rb
index 5c420bf..3283e63 100755
--- a/tool/rbinstall.rb
+++ b/tool/rbinstall.rb
@@ -44,7 +44,7 @@ def parse_args(argv = ARGV)
   $script_mode = nil
   $strip = false
   $cmdtype = (if File::ALT_SEPARATOR == '\\'
-                File.exist?("rubystub.exe") ? 'exe' : 'bat'
+                File.exist?("rubystub.exe") ? 'exe' : 'cmd'
               end)
   mflags = []
   opt = OptionParser.new
@@ -76,7 +76,7 @@ def parse_args(argv = ARGV)
   end
   opt.on('--installed-list [FILENAME]') {|name| $installed_list = name}
   opt.on('--rdoc-output [DIR]') {|dir| $rdocdir = dir}
-  opt.on('--cmd-type=TYPE', %w[bat cmd plain]) {|cmd| $cmdtype = (cmd unless cmd == 'plain')}
+  opt.on('--cmd-type=TYPE', %w[cmd plain]) {|cmd| $cmdtype = (cmd unless cmd == 'plain')}
   opt.on('--[no-]strip') {|strip| $strip = strip}
 
   opt.order!(argv) do |v|
@@ -489,16 +489,6 @@ install?(:local, :comm, :bin, :'bin-comm') do
       case $cmdtype
       when "exe"
         stub + shebang + body
-      when "bat"
-        [<<-"EOH".gsub(/^\s+/, ''), shebang, body, "__END__\n:endofruby\n"].join.gsub(/$/, "\r")
-          @echo off
-          @if not "%~d0" == "~d0" goto WinNT
-          #{ruby_bin} -x "#{cmd}" %1 %2 %3 %4 %5 %6 %7 %8 %9
-          @goto endofruby
-          :WinNT
-          "%~dp0#{ruby_install_name}" -x "%~f0" %*
-          @goto endofruby
-        EOH
       when "cmd"
         <<"/EOH" << shebang << body
 @"%~dp0#{ruby_install_name}" -x "%~f0" %*
Actions #1

Updated by nobu (Nobuyoshi Nakada) over 9 years ago

  • Status changed from Open to Closed
  • % Done changed from 0 to 100

Applied in changeset r49465.


rbinstall.rb: no batch installation

  • tool/rbinstall.rb (bin-comm): drop batch file installation.
    Windows 95 support has not been supported already.
    [Feature #10806]
Actions

Also available in: Atom PDF

Like0
Like0